Fix memory leak on http binary send #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All sent memory was being leaked during binary sends. The old deletion scheme didn't work because the container size was already 0 by the time the destructor was hit and it was effectively a no-op.
firedaemon-cto
pushed a commit
to FireDaemon/pion
that referenced
this pull request
Aug 27, 2020
…plunk#126) * initial set of core changes for constexpr support (issue splunk#123) * fixes for constexpr core support based on ci failures (issue splunk#123) * drive by fix for gcc9.2 warning on polymorphic exception * fixes for constexpr core support based on for cpp11 and cpp14 build variants (issue splunk#123) * more fixes for constexpr core support (issue splunk#123) - also fix for issue splunk#124 * next round of changes for constexpr core support (issue splunk#123) * fix last msvc regression for constexpr core * driveby fix to remove detail include * 3rd round of changes for constexpr * yet another msvc fix for cpp14 * minor doc fix for issue splunk#127 - tm_isddst -> tm_isdst * minor doc fix for issue splunk#127 - tm_isddst -> tm_isdst * push constexpr deep into the library including date, ptime (issue splunk#123) * push constexpr deep into the library including date, ptime (issue splunk#123) * fix latests regressions from constexpr changes in older gcc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal http write buffer was allocating copies of data it never deleted.
By the time the std::vector destructor was getting called, the vector size was already 0
and any data pointers were invalid.
Extending std::vector here is questionable, but this should patch the memory leak
with minimal impact on the existing code.