Adds cmake package configuration and version file to enable find_package(libpion) #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age(libpion).
This allows users of the library to include it easily :
find_package(libpion @LIBPION_LIBRARY_VERSION@ REQUIRED)
link_directories(${LIBPION_LIBRARY_DIRS})
include_directories(${LIBPION_INCLUDE_DIRS})
target_link_libraries(yourTarget ${LIBPION_LIBRARIES})
|
Is there any interest in this ? |
|
@daminetreg Looks good to me. |
|
Sorry for long delay in merging this, guys. Unfortunately we are not using cmake (yet?) so I have no easy way to verify this pull request. |
vshcherbakov
added a commit
that referenced
this pull request
Feb 6, 2015
Adds cmake package configuration and version file to enable find_package(libpion)
|
@vshcherbakov it is never too late to start using cmake ;-) |
|
Thank you very much 👍 It's easy to reuse it this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi dear splunk developers team,
I was just about to use your library in my project and noticed that your cmake build didn't add package-config, but personally I wished to be able to find_package pion, so I simply added the necessary steps for this.
This allows users of the library to include it easily then :
find_package(libpion 5.0.6 REQUIRED)
link_directories(${LIBPION_LIBRARY_DIRS})
include_directories(${LIBPION_INCLUDE_DIRS})
target_link_libraries(yourTarget ${LIBPION_LIBRARIES})
It also has the advantages that if different version are on the system, only the right one is taken.
Thanks for this http library 😃
Cheers,