Skip to content
This repository has been archived by the owner on Dec 17, 2021. It is now read-only.

feat: Replace multiple SNMP walks with one SNMP Bulk #100

Merged
merged 45 commits into from
Aug 10, 2021

Conversation

omrozowicz-splunk
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

CLA Assistant Lite bot CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 198 files.

Valid Invalid Ignored Fixed
33 4 161 0
Click to see the invalid file list
  • tests/mib_walk_data/if_mib_walk.json
  • tests/mib_walk_data/if_mib_walk_invalid_indexes.json
  • tests/mib_walk_data/if_mib_walk_invalid_networks.json
  • tests/test_tasks.py

tests/test_tasks.py Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@lstoppa lstoppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2021

Codecov Report

Merging #100 (da1dea2) into develop (7699591) will increase coverage by 4.77%.
The diff coverage is 60.37%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #100      +/-   ##
===========================================
+ Coverage    40.33%   45.10%   +4.77%     
===========================================
  Files           22       23       +1     
  Lines          838      909      +71     
===========================================
+ Hits           338      410      +72     
+ Misses         500      499       -1     
Impacted Files Coverage Δ
splunk_connect_for_snmp_poller/manager/poller.py 0.00% <ø> (ø)
..._connect_for_snmp_poller/manager/task_utilities.py 20.83% <25.64%> (+2.22%) ⬆️
splunk_connect_for_snmp_poller/manager/tasks.py 38.09% <51.85%> (+38.09%) ⬆️
tests/test_tasks.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7699591...da1dea2. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2021

Expected release notes (by @omrozowicz-splunk)

features:
ADDON-37033 (implement bulk operation for non-oid profiles) (bd0e414)
extract IF-MIB data from an SNMPWALK (#96) (7699591)
support polling the same IP address using multiple profiles (#92) (a6320ca)

fixes:
forced commit for creating new release (f3081c1)

others (will not be included in Semantic-Release notes):
da1dea2 add casting for variable in a single get scenario
ed9a596 change mib_string_handler description from snmpwalk to snmpbulkwalk
74b6f6e format task_utilities file
883b5a4 format task_utilities file
7d22b3f implement _any_failures_happened function to avoid duplicates
f43fa88 attempt to fix linter workflow
0a3caaf attempt to fix linter workflow
92e0693 attempt to fix linter workflow
743dcca format imports
1ba2fb6 reorganize imports in test file
744a920 cleanup unit tests
7d85f6a reformat code
fc5506b add mocking for imports in unit tests
836c617 add mocking for imports in unit tests
759342e rename get_data, walk_handler and get_handler
b547660 add mock for mib_string_handler in unit tests
0445f6c Update tests/test_tasks.py
85a79b3 code refactor with black
ee881f5 add casting for get varbinds
f7bc020 update unit tests
a6a2acc refactor and change unit tests
9d5cbcd fix bulk for * oids
6458cf4 fix casting bug
eb6fcd5 revert commented lines
ee25483 update mib_string_handler
1e9f520 update get method
4800347 fix walk/get mismatch
ea8c289 change get to walk
c926fe3 add debug logger for collection
5a8a6ae bring back debug loggers
b9bf11b 1. remove debug logs 2. small refactor 3. add unit tests
861350e add info loggers
643df21 add debug loggers
edf2ae6 add debug loggers
3a1d279 add debug loggers
a46cd14 add debug loggers
756c496 add debug loggers
13a91f3 delete debug lines
a64a260 delete debug lines
e403bf8 delete debug lines
e6f1089 add ObjectType/ObjectIdentity casting of oid values for bulk action
e3b12f1 add ObjectType/ObjectIdentity casting of oid values for bulk action
8aa1377 delete debug helpers
ebe3ebf Feature/redo walk (#95)
d5879c5 Stubs for lint
9cff184 Stubs for lint
adddbea Stubs for lint
5dc1549 Stubs for lint
2c5a5c3 Feat/multiple profiles2 (#93)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@omrozowicz-splunk
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@omrozowicz-splunk omrozowicz-splunk merged commit 33acbbf into develop Aug 10, 2021
@omrozowicz-splunk omrozowicz-splunk deleted the get_to_bulk_change branch August 10, 2021 09:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2021
@ryanfaircloth
Copy link
Contributor

🎉 This PR is included in version 1.5.0-develop.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants