-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Replace multiple SNMP walks with one SNMP Bulk #100
Conversation
2. small refactor 3. add unit tests
CLA Assistant Lite bot CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 198 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
33 | 4 | 161 | 0 |
Click to see the invalid file list
- tests/mib_walk_data/if_mib_walk.json
- tests/mib_walk_data/if_mib_walk_invalid_indexes.json
- tests/mib_walk_data/if_mib_walk_invalid_networks.json
- tests/test_tasks.py
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Codecov Report
@@ Coverage Diff @@
## develop #100 +/- ##
===========================================
+ Coverage 40.33% 45.10% +4.77%
===========================================
Files 22 23 +1
Lines 838 909 +71
===========================================
+ Hits 338 410 +72
+ Misses 500 499 -1
Continue to review full report at Codecov.
|
Expected release notes (by @omrozowicz-splunk) features: fixes: others (will not be included in Semantic-Release notes):
|
I have read the CLA Document and I hereby sign the CLA |
🎉 This PR is included in version 1.5.0-develop.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.