test: update test cases

splunk · Aug 3, 2022 · 05d3d4d · 05d3d4d
1 parent c146f8f
commit 05d3d4d
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/out/spec.js b/out/spec.js
@@ -487,7 +487,7 @@ function isSettingValid(specConfig, stanzaName, settingString) {
         // Look for this exact setting in the specConfig
         if(specSetting["name"] == settingName) {
             // The setting name is valid, is the setting value valid also?
-            isValid = isValueValid(specSetting["value"], settingValue);
+            isValid = isValueValid(specSetting["value"], settingValue)
 
         } else if (SETTING_PREFIX_REGEX.test(specSetting["name"])) {
 
@@ -508,7 +508,7 @@ function isSettingValid(specConfig, stanzaName, settingString) {
             // For example <tag1>
             // If a setting is in this form, anything goes.
 
-            isValid = isValueValid(specSetting["value"], settingValue);
+            isValid = isValueValid(specSetting["value"], settingValue)
         }
     });
 

diff --git a/test/spec.test.js b/test/spec.test.js
@@ -26,6 +26,22 @@ describe('authorize.conf', () => {
 	});
 });
 
+describe('authentication.conf', () => {
+	let specFileName = "authentication.conf.spec";
+	let specFilePath = path.join(specFolderLocation, specFileVersion, specFileName)
+	let specConfig = splunkSpec.getSpecConfig(specFilePath);
+
+	it('setting "clientCert = my_valid_string" should be valid for stanza [saml]', () => {
+		assert.equal(splunkSpec.isSettingValid(specConfig, "[saml]", "clientCert = my_valid_string"), true);
+	});
+	it('setting "entityId = my_valid_string" should be valid for stanza [saml]', () => {
+		assert.equal(splunkSpec.isSettingValid(specConfig, "[saml]", "entityId = my_valid_string"), true);
+	});
+	it('setting "user1 = admin::user1::user1@email.com" should be valid for stanza [userToRoleMap_SAML]', () => {
+		assert.equal(splunkSpec.isSettingValid(specConfig, "[userToRoleMap_SAML]", "user1 = admin::user1::user1@email.com"), true);
+	});
+});
+
 describe('distsearch.conf', () => {
 	let specFileName = "distsearch.conf.spec";
 	let specFilePath = path.join(specFolderLocation, specFileVersion, specFileName)
@@ -34,6 +50,10 @@ describe('distsearch.conf', () => {
 	it('stanza "[replicationBlacklist]" should be valid', () => {
 		assert.equal(splunkSpec.isStanzaValid(specConfig, "[replicationBlacklist]"), true);
 	});
+
+	it('stanza "[default]" should be valid', () => {
+		assert.equal(splunkSpec.isStanzaValid(specConfig, "[default]"), true);
+	});
 });
 
 describe('indexes.conf', () => {
@@ -83,6 +103,14 @@ describe('inputs.conf', () => {
 		assert.equal(splunkSpec.isSettingValid(specConfig, "[script://./bin/lsof.sh]", "interval = 600"), true);
 	});
 
+	it('setting python.version = python4 should be invalid', () => {
+		assert.notEqual(splunkSpec.isSettingValid(specConfig, "[my_modular_input]", "python.version = python4"), true);
+	});
+
+	it('setting python.version = python3 should be valid', () => {
+		assert.equal(splunkSpec.isSettingValid(specConfig, "[my_modular_input]", "python.version = python3"), true);
+	});
+
 });
 
 describe('serverclass.conf', () => {