improve spm install #804
improve spm install #804
Conversation
sorrycc
commented
May 29, 2014
sorrycc
commented
- install package@stable 时，如果 sea-modules 里存在对应版本号，直接返回 found，而不从 cache 里解压
- 基于 stream，减少文件读写
| if (err) { | ||
| callback(err); | ||
| return; | ||
| } | ||
|
|
||
| var relativePath = path.relative(process.cwd(), dest); | ||
| log.info('installed', color.green(relativePath)); | ||
| var pkg = file.readJSON(path.join(dest, 'package.json')); |
There was a problem hiding this comment.
原来的 src 是指 tmp 下的临时 package 路径，改完后没走 tmp 了。
|
删了好多代码，清爽了好多 |
| var log = require('./utils/log'); | ||
| var yuan = require('./sdk/yuan'); | ||
| var iduri = require('./sdk/iduri'); | ||
| var file = require('./sdk/file'); | ||
| var mo = require('./sdk/module'); | ||
| var gulp = require('gulp'); | ||
| var gunzip = require('gulp-gunzip'); | ||
| var untar = require('gulp-untar'); |
There was a problem hiding this comment.
gulp-untar 估计把测试文件也发上去了，我这里看 70M+。重新发了个 gulp-untar2 上去，只有 1.5M 了。
There was a problem hiding this comment.
给他 pr 去—
Sent from Mailbox for iPhone
On Fri, May 30, 2014 at 11:23 AM, chencheng (云谦) notifications@github.com
wrote:
var log = require('./utils/log');
var yuan = require('./sdk/yuan');
var iduri = require('./sdk/iduri');
var file = require('./sdk/file');
var mo = require('./sdk/module');
+var gulp = require('gulp');
+var gunzip = require('gulp-gunzip');
+var untar = require('gulp-untar');gulp-untar 估计把测试文件也发上去了，我这里看 70M+。重新发了个 gulp-untar2 上去，只有 1.5M 了。
Reply to this email directly or view it on GitHub:
https://github.com/spmjs/spm/pull/804/files#r13215395
There was a problem hiding this comment.
没法 pr ，源码没问题，publish 的包多了个 out 文件夹，看不明白。已经提了 issue 。
There was a problem hiding this comment.
问题是他源文件里也没有那个测试文件。。pr 了一个缺失的 dep 依赖，他重新发布应该就好了。
jmerrifield/gulp-untar#1
