Added support for KHR_materials_pbrSpecularGlossiness. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DragonJoker
commented
Sep 6, 2023
DragonJoker
force-pushed
the
add_KHR_materials_pbrSpecularGlossiness
branch
from
183650f
to
22952b6
Compare
DragonJoker
force-pushed
the
add_KHR_materials_pbrSpecularGlossiness
branch
from
22952b6
to
8e53e7e
Compare
spnda
reviewed
Sep 7, 2023
|
I guess it would also make sense to add a Actions runner that would also run the tests with the define enabled. Right now, the tests never get built through CI for the extension. |
spnda
requested changes
Sep 7, 2023
spnda
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.