New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Bad chunk padding for GLB export #57

Merged

spnda merged 1 commit into spnda:main from Cyphall:glb-padding-fix

Mar 12, 2024

Contributor

Cyphall commented Mar 12, 2024

This PR fixes two bugs:

The trailing padding for the BIN chunk was applied between chunkType and chunkData instead of after chunkData (terms from the glTF Specs)
The padding code was not adding the right amount of bytes (e.g. for a chunk size of 11, it was adding 3 bytes instead of 1).

I also refactored a few lines to have the same code structure of "write and pad" for the JSON and BIN chunks


          Fix: Bad chunk padding for GLB export

6ca5520

spnda approved these changes

View reviewed changes

spnda merged commit c1be0f8 into spnda:main

14 checks passed

Owner

spnda commented Mar 12, 2024

Thank you, really stupid mistake of having the padding in front of the chunk data...

Cyphall deleted the glb-padding-fix branch

March 12, 2024 13:48

spnda pushed a commit that referenced this pull request


          Fix: Bad chunk padding for GLB export (#57)

863fb2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet