New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Accessor's component type is forced #59

Merged

spnda merged 1 commit into spnda:main from Razakhel:fix-accessor-mixed-types

Apr 11, 2024

Contributor

Razakhel commented Apr 11, 2024

Context

Problem occurred on a GLB file that had an indices accessor of an unsigned short component type, but with their max & min bounds written as double values. This is valid by the glTF spec, as per https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#_accessor_max and https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#_accessor_min:

Array elements MUST be treated as having the same data type as accessor’s componentType.


          Fix: Accessor's component type is forced

a51fdd4

spnda approved these changes

View reviewed changes

spnda merged commit 7352629 into spnda:main

14 checks passed

Razakhel deleted the fix-accessor-mixed-types branch

April 11, 2024 18:30

spnda pushed a commit that referenced this pull request


          Fix: Always allow floating-point min/max accessor values (#59)

8ce583d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet