Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spock-tapestry: added support for @InjectService, @javax.inject.Inject #12

merged 3 commits into from
Mar 17, 2013


Copy link

@tawus tawus commented Jan 25, 2013

Added support for the preferred way of injection using @javax.inject.Inject. Also added support for @InjectService.

Copy link

Thanks for the pull request! Looks good. Would you mind to update your code to avoid static references to @javax.inject.Inject so that we stay compatible with JDK 5? You could use org.spockframework.util.ReflectionUtil.isAnnotationPresent for production code, and org.spockframework.EmbeddedSpecification for test code.

Copy link

tawus commented Jan 28, 2013

Thanks Peter for accepting the request. I have removed the references to javax.inject.Inject.

BTW EmbeddedSpecRunner is very cool!

@pniederw pniederw merged commit aba2e4f into spockframework:groovy-1.8 Mar 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants