Skip to content

Conversation

@tawus
Copy link

@tawus tawus commented Jan 25, 2013

Added support for the preferred way of injection using @javax.inject.Inject. Also added support for @InjectService.

@pniederw
Copy link
Contributor

Thanks for the pull request! Looks good. Would you mind to update your code to avoid static references to @javax.inject.Inject so that we stay compatible with JDK 5? You could use org.spockframework.util.ReflectionUtil.isAnnotationPresent for production code, and org.spockframework.EmbeddedSpecification for test code.

@tawus
Copy link
Author

tawus commented Jan 28, 2013

Thanks Peter for accepting the request. I have removed the references to javax.inject.Inject.

BTW EmbeddedSpecRunner is very cool!

@pniederw pniederw merged commit aba2e4f into spockframework:groovy-1.8 Mar 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants