Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExceptionAdapterExtension to also handle inherited fixture methods #1264

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

leonard84
Copy link
Member

fixes #1263

@leonard84 leonard84 enabled auto-merge (squash) January 21, 2021 14:12
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #1264 (e4d6e75) into master (9628409) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1264      +/-   ##
============================================
+ Coverage     76.58%   76.60%   +0.02%     
  Complexity     3764     3764              
============================================
  Files           405      405              
  Lines         11464    11461       -3     
  Branches       1395     1395              
============================================
  Hits           8780     8780              
+ Misses         2201     2198       -3     
  Partials        483      483              
Impacted Files Coverage Δ Complexity Δ
...ockframework/junit4/ExceptionAdapterExtension.java 100.00% <100.00%> (ø) 4.00 <2.00> (-3.00)
...ava/org/spockframework/runtime/model/SpecInfo.java 90.27% <0.00%> (+2.08%) 72.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9628409...e4d6e75. Read the comment docs.

@leonard84 leonard84 merged commit d2aa039 into spockframework:master Jan 21, 2021
@leonard84 leonard84 deleted the fix-1263 branch January 21, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JUnit4 assumptions fail the tests when coming from setup() method of a super spec
2 participants