Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent removal of ErrorSpecNode from execution hierarchy #1358

Merged

Conversation

leonard84
Copy link
Member

As the ErrorSpecNode does not have children it would get removed
when trying to select specific tests methods
For example, gradle will report that no test were found,
and not report the actual error.

As the ErrorSpecNode does not have children it would get removed
when trying to select specific tests methods
For example, gradle will report that no test were found,
and not report the actual error.
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #1358 (d5c3745) into master (9da9608) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1358   +/-   ##
=========================================
  Coverage     79.22%   79.22%           
- Complexity     3943     3946    +3     
=========================================
  Files           408      408           
  Lines         12262    12263    +1     
  Branches       1617     1616    -1     
=========================================
+ Hits           9714     9715    +1     
  Misses         1967     1967           
  Partials        581      581           
Impacted Files Coverage Δ
...java/org/spockframework/runtime/ErrorSpecNode.java 83.33% <100.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9da9608...d5c3745. Read the comment docs.

@leonard84 leonard84 merged commit b2902ca into spockframework:master Jul 17, 2021
@leonard84 leonard84 deleted the prevent_error_spec_node_removal branch July 17, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants