Add "shared." support to ConditionalExtensions #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1359 +/- ##
============================================
- Coverage 79.22% 79.20% -0.02%
- Complexity 3943 3949 +6
============================================
Files 408 408
Lines 12262 12299 +37
Branches 1617 1625 +8
============================================
+ Hits 9714 9741 +27
- Misses 1967 1975 +8
- Partials 581 583 +2
Continue to review full report at Codecov.
|
ConditionalExtensions can now access shared fields via `shared.`. If applied on the Specification level, this causes the shared field initializers and `setupSpec` methods to run. If a ConditionalExtension applied on the Specification level uses `instance.` it will now behave as if it was applied on every feature.
leonard84
force-pushed
the
access_to_shared_in_precondition_context
branch
from
ef46e1c
to
c97167b
Compare
marcphilipp
approved these changes
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConditionalExtensions can now access shared fields via
shared..If applied on the Specification level, this causes the shared field initializers
and
setupSpecmethods to run.If a ConditionalExtension applied on the Specification level uses
instance.itwill now behave as if it was applied on every feature.