Fix selector ordering issue#1375
Merged
leonard84 merged 2 commits intospockframework:masterfrom Oct 3, 2021
Merged
Conversation
Prior to this commit the callback that is called when an entire test class is selected enabled all feature methods on the wrong `SpecInfo` instance which was part of the closure. Co-authored-by: Leonard Brünings <lbruenings@gradle.com>
Codecov Report
@@ Coverage Diff @@
## master #1375 +/- ##
=========================================
Coverage 79.26% 79.26%
+ Complexity 3950 3948 -2
=========================================
Files 402 402
Lines 12290 12290
Branches 1625 1626 +1
=========================================
Hits 9742 9742
Misses 1965 1965
Partials 583 583
Continue to review full report at Codecov.
|
leonard84
approved these changes
Oct 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit the callback that is called when an entire test
class is selected enabled all feature methods on the wrong
SpecInfoinstance which was part of the closure.