Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to omit feature name from iterations #1386

Merged

Conversation

leonard84
Copy link
Member

No description provided.

@leonard84 leonard84 requested a review from szpak October 16, 2021 10:34
@leonard84 leonard84 self-assigned this Oct 16, 2021
@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #1386 (d9ee9ce) into master (30fd640) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1386      +/-   ##
============================================
+ Coverage     79.28%   79.30%   +0.02%     
- Complexity     3978     3986       +8     
============================================
  Files           403      403              
  Lines         12391    12406      +15     
  Branches       1639     1640       +1     
============================================
+ Hits           9824     9839      +15     
  Misses         1971     1971              
  Partials        596      596              
Impacted Files Coverage Δ
...rk/runtime/DataVariablesIterationNameProvider.java 100.00% <100.00%> (ø)
...runtime/extension/builtin/UnrollConfiguration.java 100.00% <100.00%> (ø)
...ork/runtime/extension/builtin/UnrollExtension.java 100.00% <100.00%> (ø)
...extension/builtin/UnrollIterationNameProvider.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30fd640...d9ee9ce. Read the comment docs.

Copy link
Member

@szpak szpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation for parametrized tests (to include those new placeholders).

@szpak szpak added this to the 2.1 milestone Oct 17, 2021
@leonard84 leonard84 force-pushed the data-driven_without_featureName branch from 673f95f to 06a851e Compare October 24, 2021 17:36
@leonard84 leonard84 marked this pull request as ready for review October 25, 2021 18:11
@leonard84 leonard84 requested a review from szpak October 25, 2021 18:11
szpak
szpak previously approved these changes Oct 25, 2021
docs/data_driven_testing.adoc Outdated Show resolved Hide resolved
@leonard84 leonard84 merged commit 00c889c into spockframework:master Nov 11, 2021
@leonard84 leonard84 deleted the data-driven_without_featureName branch November 11, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants