Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the AST transformation more robust against missing classes in the compile classpath #1704

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

Vampire
Copy link
Member

@Vampire Vampire commented Jun 28, 2023

No description provided.

@Vampire
Copy link
Member Author

Vampire commented Jun 28, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (62b11bb) 79.78% compared to head (2396740) 79.79%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1704   +/-   ##
=========================================
  Coverage     79.78%   79.79%           
- Complexity     4069     4072    +3     
=========================================
  Files           425      425           
  Lines         12898    12900    +2     
  Branches       1628     1628           
=========================================
+ Hits          10291    10293    +2     
  Misses         1999     1999           
  Partials        608      608           
Files Changed Coverage Δ
...org/spockframework/compiler/SpecialMethodCall.java 93.26% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

build.gradle Outdated Show resolved Hide resolved
@Vampire Vampire requested a review from leonard84 August 15, 2023 19:13
@Vampire Vampire force-pushed the compiler-robustness branch 2 times, most recently from 876bc11 to eb9854c Compare August 21, 2023 16:15
@leonard84 leonard84 enabled auto-merge (rebase) August 21, 2023 18:02
@leonard84 leonard84 enabled auto-merge (squash) August 21, 2023 18:03
@leonard84 leonard84 merged commit 2fff484 into master Aug 21, 2023
36 checks passed
@leonard84 leonard84 deleted the compiler-robustness branch August 21, 2023 20:43
@leonard84 leonard84 added this to the 2.4-M2 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants