Use multiple locks in ByteBuddyMockFactory to reduce lock contention #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1778 +/- ##
=============================================
+ Coverage 0 79.83% +79.83%
- Complexity 0 4077 +4077
=============================================
Files 0 425 +425
Lines 0 12916 +12916
Branches 0 1630 +1630
=============================================
+ Hits 0 10311 +10311
- Misses 0 1998 +1998
- Partials 0 607 +607
☔ View full report in Codecov by Sentry. |
Vampire
requested changes
Sep 4, 2023
spock-core/src/main/java/org/spockframework/mock/runtime/ByteBuddyMockFactory.java
Outdated
Show resolved
Hide resolved
spock-core/src/main/java/org/spockframework/mock/runtime/ByteBuddyMockFactory.java
Outdated
Show resolved
Hide resolved
spock-core/src/main/java/org/spockframework/mock/runtime/ByteBuddyMockFactory.java
Show resolved
Hide resolved
spock-core/src/main/java/org/spockframework/mock/runtime/ByteBuddyMockFactory.java
Outdated
Show resolved
Hide resolved
spock-core/src/main/java/org/spockframework/mock/runtime/ByteBuddyMockFactory.java
Show resolved
Hide resolved
...cs/src/test/groovy/org/spockframework/mock/runtime/ByteBuddyMockFactoryConcurrentSpec.groovy
Outdated
Show resolved
Hide resolved
...cs/src/test/groovy/org/spockframework/mock/runtime/ByteBuddyMockFactoryConcurrentSpec.groovy
Outdated
Show resolved
Hide resolved
...cs/src/test/groovy/org/spockframework/mock/runtime/ByteBuddyMockFactoryConcurrentSpec.groovy
Outdated
Show resolved
Hide resolved
...cs/src/test/groovy/org/spockframework/mock/runtime/ByteBuddyMockFactoryConcurrentSpec.groovy
Outdated
Show resolved
Hide resolved
spock-core/src/main/java/org/spockframework/mock/runtime/ByteBuddyMockFactory.java
Outdated
Show resolved
Hide resolved
Changed locking scheme in ByteBuddyMockFactory from a single global lock CACHE to cacheLocks with size 16. The used TypeCachingLock from cacheLocks depends on the hashcode of TypeCache.SimpleKey, which aggregates the types to mock. The old global CACHE lock did block Threads regardless, if they try to mock the same type or not. This is a similar fix as in Mockito: mockito/mockito#3095 Co-authored-by: Björn Kautler <Bjoern@Kautler.net>
leonard84
added a commit
to AndreasTu/spock
that referenced
this pull request
Sep 15, 2023
…ctedConst * spockframework/master: Use multiple locks in ByteBuddyMockFactory to reduce lock contention (spockframework#1778) Fixup LICENSE file after change to geantyref (spockframework#1773) # Conflicts: # spock-core/src/main/java/org/spockframework/mock/runtime/ByteBuddyMockFactory.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed locking scheme in ByteBuddyMockFactory from a single global lock CACHE to cacheLocks with size 16.
The used TypeCachingLock from cacheLocks depends on the hashcode of TypeCache.SimpleKey,
which aggregates the types to mock.
The old global CACHE lock did block Threads regardless, if they try to mock the same type or not.
This is a similar fix as in Mockito:
Mockito 3095