Allow to create Groovy spies with existing instances

[Vampire]

No description provided.

[Vampire]

• Allow to create Groovy spies with existing instances #1825 👈
• Add missing closure hints for Spy(T, Closure) #1786
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Vampire and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 80.33%. Comparing base (2c7db77) to head (18556f9).
Report is 51 commits behind head on master.

❗ Current head 18556f9 differs from pull request most recent head af671b7. Consider uploading reports for the commit af671b7 to get more accurate results

Files	Patch %	Lines
...pock-core/src/main/java/spock/mock/MockingApi.java	0.00%	4 Missing ⚠️
...in/java/org/spockframework/lang/SpecInternals.java	66.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1825      +/-   ##
============================================
- Coverage     80.44%   80.33%   -0.12%     
+ Complexity     4337     4309      -28     
============================================
  Files           441      439       -2     
  Lines         13534    13484      -50     
  Branches       1707     1702       -5     
============================================
- Hits          10888    10832      -56     
  Misses         2008     2008              
- Partials        638      644       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leonard84]

Is this testing that it works? When you don't customize the instance, how would you notice the difference to the parameter being ignored?

[Vampire]

Afair I just ported over the tests from JavaSpies where it is done the same.

[Vampire]

Also, I'm not sure what you mean.
Calling the method on the Spy calls through to the original object.
What should be customized here?
That the Spy can intercept and change things is tested further down.

[leonard84]

I was talking about creating Person with non-default constructor values. Otherwise, it would behave the same as GroovySpy().

[Vampire]

What would that change?
The tested method is not influenced by the constructor arguments or any property of the class.
Again, I just ported over the test from JavaSpies, assuming that whoever invented them had a reason to write them like that.