Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature scoped interceptors... #1844

Merged

Conversation

leonard84
Copy link
Member

of initializer/setup/cleanup methods.

@leonard84 leonard84 self-assigned this Dec 10, 2023
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2c7db77) 80.44% compared to head (66ab97c) 80.77%.
Report is 13 commits behind head on master.

Files Patch % Lines
.../org/spockframework/runtime/model/FeatureInfo.java 89.47% 1 Missing and 1 partial ⚠️
...org/spockframework/runtime/PlatformSpecRunner.java 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1844      +/-   ##
============================================
+ Coverage     80.44%   80.77%   +0.32%     
- Complexity     4337     4386      +49     
============================================
  Files           441      442       +1     
  Lines         13534    13767     +233     
  Branches       1707     1726      +19     
============================================
+ Hits          10888    11120     +232     
+ Misses         2008     2005       -3     
- Partials        638      642       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonard84 leonard84 force-pushed the feature-scoped-initializers branch 2 times, most recently from d3aa0f0 to c5141f1 Compare December 13, 2023 18:00
Comment on lines +901 to +1019
[source,groovy,indent=0]
----
include::{sourcedir}/extension/InterceptorSpec.groovy[tag=interceptor-class]
----
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just leave this out?
It does not really add much value.

Copy link
Member Author

@leonard84 leonard84 Dec 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, we'd need to replace the I in the examples. It is only separate because I couldn't find a way to get rid of the indent for the other includes otherwise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to replace it?
Or do I expect too much transfer ability from the reader that he knows that is a class implementing the listener interface?
Then we could keep it of course. :-D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the worst case, they could look at the doc-spec where this is coming from. :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or do I expect too much transfer ability from the reader that he knows that is a class implementing the listener interface?

Yes, I think for new readers it would be confusing.

In the worst case, they could look at the doc-spec where this is coming from. :-)

🤔 It would be nice to automatically have a link to the sources under the code snippets.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your wish is my command: #1904 :-)

@leonard84 leonard84 force-pushed the feature-scoped-initializers branch 2 times, most recently from 3437800 to a7642b5 Compare December 17, 2023 20:13
@leonard84 leonard84 force-pushed the feature-scoped-initializers branch 2 times, most recently from c6874b0 to bc059a5 Compare February 17, 2024 10:35
@leonard84 leonard84 enabled auto-merge (squash) February 18, 2024 20:03
@leonard84 leonard84 requested review from Vampire and removed request for Vampire February 19, 2024 09:14
@leonard84 leonard84 merged commit 31fd34c into spockframework:master Feb 20, 2024
23 checks passed
@leonard84 leonard84 deleted the feature-scoped-initializers branch February 20, 2024 16:34
@leonard84 leonard84 added this to the 2.4-M2 milestone Feb 22, 2024
Copy link
Member

@Vampire Vampire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants