added manifest to core.gradle to allow spock core to work in OSGi land#40
Merged
Merged
Conversation
Contributor
|
It would be useful if this could be merged as well. |
Contributor
|
This is now merged. Thanks for the PR and reminder. It would be great if we had a way to automatically verify the correctness of the bundle manifest. |
Contributor
|
I work with Jordan. I'll see if we can add a test that would deploy it out to a container in a unit test and verify it is working properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a manifest to the spock-core jar so the jar can be deployed as a bundle to an OSGi container.