Upgraded Gradle and Groovy versions #521
Conversation
paplorinc
force-pushed
the
GradleUpgrade
branch
from
32df483
to
07d631d
Compare
| @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| zipStoreBase=GRADLE_USER_HOME | |||
| zipStorePath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-2.3-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-2.6-bin.zip | |||
There was a problem hiding this comment.
While you are at it you can update the wrapper as well, since it supports sha256 based validation as of 2.5.
https://docs.gradle.org/current/userguide/gradle_wrapper.html
There was a problem hiding this comment.
Regarding checksum validation and regenerated wrapper there is a known issue in 2,6 that have negative performance impact. It should be already fixed in 2.7-rc-1.
There was a problem hiding this comment.
Final 2.7 will be out shortly, will push the rc-2 until then (which has the fix for the performance regression)
There was a problem hiding this comment.
I see a change in gradle-wrapper.properties, but to get the new wrapper features (like checksum validation) it is required to regenerate wrapper jar (./gradlew wrapper).
There was a problem hiding this comment.
Yes, please see the latest patchset (https://github.com/spockframework/spock/pull/521/files)
There was a problem hiding this comment.
You completely are right. I overlooked Binary file not shown on the diff list.
There was a problem hiding this comment.
Could someone please retrigger the builds for my PRs, they seemed to have timed out :/
paplorinc
force-pushed
the
GradleUpgrade
branch
from
07d631d
to
ebfb905
Compare
paplorinc
changed the title
|
@paplorinc Gradle 2.7 final was released today, could you please amend this commit with the new version, and also regenerate the wrapper with 2.7 final. Then, if no one objects and the builds are green, I'll merge it. |
|
Sure, will do |
paplorinc
force-pushed
the
GradleUpgrade
branch
from
ebfb905
to
2a6ecd2
Compare
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-2.3-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-2.7-all.zip |
There was a problem hiding this comment.
I'm not seeing the sha256Sum here
There was a problem hiding this comment.
Done, please see the new commit message also
paplorinc
force-pushed
the
GradleUpgrade
branch
2 times, most recently
from
248700a
to
2401bb2
Compare
Added `distributionSha256Sum` for verification of downloaded Gradle distributions In case of wrong checksum the following error will be displayed Expected checksum: '2ba0aaa11a3e96ec0af31d532d808e1f09cc6dcad0954e637902a1ab544b9e60' Actual checksum: '<invalid SHA 256 checksum, which can be used for calculation of the next versions also>' See: https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:verification
Upgraded Gradle and Groovy versions
|
The AppVeyor builds fail due to an unrelated issue, so we'll ignore those results. |
Added
distributionSha256Sumfor verification of downloaded Gradle distributionsIn case of wrong checksum the following error will be displayed
Expected checksum: '2ba0aaa11a3e96ec0af31d532d808e1f09cc6dcad0954e637902a1ab544b9e60'
Actual checksum: '<invalid SHA 256 checksum, which can be used for calculation of the next versions also>'
See: https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:verification