Fix erroneous regex where an optional colon was defined instead of a non-capturing group #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
=========================================
Coverage 75.96% 75.96%
Complexity 3528 3528
=========================================
Files 376 376
Lines 10722 10722
Branches 1360 1360
=========================================
Hits 8145 8145
Misses 2104 2104
Partials 473 473
Continue to review full report at Codecov.
|
…non-capturing group
Vampire
force-pushed
the
fix-erroneous-regex
branch
from
abc928c
to
45fcc3e
Compare
leonard84
approved these changes
Oct 14, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is