Fix quart signals upgrade #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quart changed how it is initializing signals, removing the AsyncNamespace class jinja2-fragments was relying on. Hence, the library was not usable with Quart>=0.19.0, which is when this change became effective. This commit adds support for both Quart<=19.0.0 and Quart>=19.0.0. Ref: #19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quart changed how it is initializing signals, removing the
AsyncNamespaceclass jinja2-fragments was relying on. Hence, the jinja2-fragments was not compatible with Quart>=0.19.0, which is when this change became effective.This commit adds support for both Quart<=19.0.0 and Quart>=19.0.0.
It also changes the Quart tests to not run on Python<3.8, as Quart requires 3.8 or higher.
Ref: #19