Implements asyncio support for nirum compiler #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kroisse
suggested changes
Aug 14, 2017
| @@ -890,8 +905,8 @@ class {className}_Client($className): | |||
| et <- compileTypeExpression src errorTypeExpression | |||
| return $ Just [qq|('{toAttributeName' mn}', $et)|] | |||
| Nothing -> return Nothing | |||
| compileMethod :: Method -> CodeGen Code | |||
| compileMethod m@(Method mName params rtype _etype _anno) = do | |||
| compileMethod :: Bool -> Method -> CodeGen Code | |||
There was a problem hiding this comment.
Bool을 그대로 쓰기보다는 async 여부를 나타낼 수 있는 새로운 타입을 정의하는 것을 추천합니다.
| name = "nirum" | ||
| email = "dev@nirum.org" | ||
|
|
||
| [targets] |
| service pong-service ( | ||
| bool pong (), | ||
|
|
||
|
|
|
|
||
|
|
||
| def test_async_disabled(): | ||
| service = PingService_Async() |
There was a problem hiding this comment.
support_async = false인 경우엔 아예 PingService_Async가 생성되지 않아야 하지 않을까 생각합니다. 어차피 생성된다고 해도 진짜 async 버전과 서로 인터페이스가 호환되지도 않을 테고요.
|
Python 3.4 does not supports |
dahlia
added
cat:packaging
dahlia
force-pushed
the
master
branch
13 times, most recently
from
7d5a611
to
12a5ff2
Compare
|
It's 2018 — I think Python 3.4 support could be dropped since aiohttp now supports only Python 3.5.3+ and major Linux distros come with Python 3.5+ now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting asyncio is configurable with
support_asyncflag inpackage.toml.To implement this option, I implemented boolean field handling in
Package/metadata.hs.If the
support_asyncflag is set totrue, my nirum fork creates another service module{className}_Asyncand putasync defkeyword to methods, instead ofdefkeywords.To implement tox unit tests, I created another fixture in
test/nirum_fixture_async. It just contains a service with oneboolfield.