Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table syntax extension on docstrings #288

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Table syntax extension on docstrings #288

merged 1 commit into from
Jul 10, 2018

Conversation

dahlia
Copy link
Member

@dahlia dahlia commented Jul 8, 2018

This patch makes docstrings support table syntax extension.

@dahlia dahlia added typ:enhance Type: Enhancement/new feature cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) target:docs cat:lang Category: Language design cmp:frontend Component: Compiler frontend (e.g., CLI, parser, AST) labels Jul 8, 2018
@dahlia dahlia self-assigned this Jul 8, 2018
@dahlia dahlia requested a review from kanghyojun July 8, 2018 10:14
@codecov
Copy link

codecov bot commented Jul 8, 2018 •
edited
Loading

Codecov Report

Merging #288 into master will increase coverage by 0.42%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   77.19%   77.61%   +0.42%     
==========================================
  Files          34       34              
  Lines        2670     2734      +64     
  Branches      144      147       +3     
==========================================
+ Hits         2061     2122      +61     
  Misses        465      465              
- Partials      144      147       +3
Impacted Files Coverage Δ
src/Nirum/Docs/Html.hs 64.81% <100%> (+9.25%) ⬆️
src/Nirum/Docs.hs 62.35% <84.21%> (+3.44%) ⬆️
src/Nirum/Docs/ReStructuredText.hs 62.18% <93.18%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bd7eba...d4a9b93. Read the comment docs.

kanghyojun
kanghyojun reviewed Jul 10, 2018
View reviewed changes
src/Nirum/Docs/Html.hs
<tbody>{T.concat (fmap tr $ Data.List.NonEmpty.tail rows)}</tbody></table>|]
where
lf :: Char
lf = '\n'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

kanghyojun
kanghyojun approved these changes Jul 10, 2018
View reviewed changes
Copy link
Member

@kanghyojun kanghyojun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kanghyojun kanghyojun merged commit db3a689 into nirum-lang:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanghyojun kanghyojun kanghyojun approved these changes

Assignees

@dahlia dahlia

Labels
cat:lang Category: Language design cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) cmp:frontend Component: Compiler frontend (e.g., CLI, parser, AST) target:docs typ:enhance Type: Enhancement/new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dahlia @kanghyojun