You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
This isn't significant enough of an issue to warrant a release all on its own and making too many releases tends to cause gem conflicts when multiple gems that depend on addressable have conflicting version specifiers. So... no, not yet.
The reason will be displayed to describe this comment to others. Learn more.
I think what happened there was I wrote a slightly different fix that had higher performance, committed it, then realized it caused tests to fail, and then amended the commit to match your changes because they did actually work.
f6b2cc8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make a new release for this? If I use the current gem, I get warnings that were fixed by this commit.
Thanks!
f6b2cc8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't significant enough of an issue to warrant a release all on its own and making too many releases tends to cause gem conflicts when multiple gems that depend on addressable have conflicting version specifiers. So... no, not yet.
f6b2cc8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, was there a reason you didn't just pull in my identical commit/pull-request?
stephencelis@e710b61
f6b2cc8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what happened there was I wrote a slightly different fix that had higher performance, committed it, then realized it caused tests to fail, and then amended the commit to match your changes because they did actually work.