Skip to content

Commit

Permalink
Fixed warning about unused variable. Closes #47.
Browse files Browse the repository at this point in the history
  • Loading branch information
Bob Aman committed Oct 31, 2011
1 parent 2fcc4f7 commit f6b2cc8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/addressable/uri.rb
Expand Up @@ -1428,8 +1428,8 @@ def query_values(options={})
end
end
if hash != {} && hash.keys.all? { |key| key =~ /^\d+$/ }
hash.sort.inject([]) do |accu, (key, value)|
accu << value; accu
hash.keys.sort.inject([]) do |accu, key|
accu << hash[key]; accu
end
else
hash
Expand Down

4 comments on commit f6b2cc8

@joevandyk
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a new release for this? If I use the current gem, I get warnings that were fixed by this commit.

Thanks!

@sporkmonger
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't significant enough of an issue to warrant a release all on its own and making too many releases tends to cause gem conflicts when multiple gems that depend on addressable have conflicting version specifiers. So... no, not yet.

@stephencelis
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, was there a reason you didn't just pull in my identical commit/pull-request?

stephencelis@e710b61

@sporkmonger
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what happened there was I wrote a slightly different fix that had higher performance, committed it, then realized it caused tests to fail, and then amended the commit to match your changes because they did actually work.

Please sign in to comment.