Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen public suffix restriction to allow version 5.0 #460

Conversation

petergoldstein
Copy link
Contributor

public_suffix 5.0 was just released. It includes updated definitions, and is restricted to Ruby 2.6+.

Loosening this gemspec restriction allows addressable to use the latest version of public_suffix when loaded with a supported Ruby (2.6+).

public_suffix 5.0 was just released.  It includes updated definitions, and is restricted to Ruby 2.6+.

Loosening this restriction allows addressable to use the latest version of public_suffix when loaded with a supported Ruby.
@petergoldstein
Copy link
Contributor Author

CI failures appears to be unrelated, because the same Windows/JRuby 9.3 failures are happening in this PR - #459 - as well.

@dentarg
Copy link
Collaborator

dentarg commented Jul 25, 2022

Change looks fine to me, no breaking API changes in public_suffix what I can see:

@dentarg dentarg merged commit d2df5e8 into sporkmonger:main Jul 25, 2022
41 checks passed
@dentarg
Copy link
Collaborator

dentarg commented Jul 25, 2022

Totally forgot the fact that there's a rake task to generate the gemspec 🤦

I'll update it

dentarg added a commit that referenced this pull request Jul 25, 2022
dentarg added a commit to dentarg/addressable that referenced this pull request Jul 25, 2022
I ran "bundle exec rake gem:gemspec" and this is what changed, except
the date (did not change the date as I think that should reflect when
releases are made).

Related to sporkmonger#460 and sporkmonger#463 that both updated the generated gemspec
directly. Includes the change from sporkmonger#425.
@dentarg dentarg mentioned this pull request Jul 25, 2022
dentarg added a commit that referenced this pull request Jul 25, 2022
I ran "bundle exec rake gem:gemspec" and this is what changed, except
the date (did not change the date as I think that should reflect when
releases are made).

Related to #460 and #463 that both updated the generated gemspec
directly. Includes the change from #425.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants