fixed rspec1? method to work correctly #263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previous implementation would always return true: declaring Spork::Test::Framework::RSpec < Spork::TestFramework causes defined?(RSpec) to always be true within the scope of Spork::Test::Framework::RSpec. see https://gist.github.com/sshao/e8c975ae4a45b2fdf512 for a pure ruby reproduction of this behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous implementation would always return true: declaring
Spork::Test::Framework::RSpec < Spork::TestFrameworkcausesdefined?(RSpec)to always be true within the scope ofSpork::Test::Framework::RSpec. see this gist for a pure ruby reproduction of this behavior.the spork spec suite already contains tests for rspec1 support, but did not catch this bug because the tests stub the
rspec1?method. I couldn't think of a way to fix the tests to catch this behavior, as it would require removing/stubbing out the::RSpecconstant for that example, but since the test suite itself uses RSpec 2 to run, removal of::RSpecwould then break the test runner.