Skip to content

Commit

Permalink
switch from paste0 URL building to using httr::modify_url and params …
Browse files Browse the repository at this point in the history 
…lists, linting
  • Loading branch information
@saiemgilani
saiemgilani committed Mar 24, 2023
1 parent a6d6492 commit 6369cbf
Show file tree
Hide file tree
Showing 19 changed files with 3,043 additions and 2,671 deletions.
221 changes: 131 additions & 90 deletions R/nba_stats_boxscore.R
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,21 @@ nba_boxscoretraditionalv2 <- function(

version <- "boxscoretraditionalv2"
endpoint <- nba_endpoint(version)
full_url <- endpoint

params <- list(
EndPeriod = end_period,
EndRange = end_range,
GameID = pad_id(game_id),
RangeType = range_type,
StartPeriod = start_period,
StartRange = start_range
)

full_url <- paste0(endpoint,
"?EndPeriod=", end_period,
"&EndRange=", end_range,
"&GameID=",pad_id(game_id),
"&RangeType=", range_type,
"&StartPeriod=",start_period,
"&StartRange=", start_range)
tryCatch(
expr = {

resp <- request_with_proxy(url = full_url, ...)
resp <- request_with_proxy(url = full_url, params = params, ...)

df_list <- nba_stats_map_result_sets(resp)

Expand Down Expand Up @@ -94,20 +97,21 @@ nba_boxscoreadvancedv2 <- function(

version <- "boxscoreadvancedv2"
endpoint <- nba_endpoint(version)


full_url <- paste0(endpoint,
"?EndPeriod=", end_period,
"&EndRange=", end_range,
"&GameID=",pad_id(game_id),
"&RangeType=", range_type,
"&StartPeriod=",start_period,
"&StartRange=", start_range)
full_url <- endpoint

params <- list(
EndPeriod = end_period,
EndRange = end_range,
GameID = pad_id(game_id),
RangeType = range_type,
StartPeriod = start_period,
StartRange = start_range
)

tryCatch(
expr = {

resp <- request_with_proxy(url = full_url, ...)
resp <- request_with_proxy(url = full_url, params = params, ...)

df_list <- nba_stats_map_result_sets(resp)

Expand Down Expand Up @@ -147,13 +151,16 @@ nba_boxscoredefensive <- function(

version <- "boxscoredefensive"
endpoint <- nba_endpoint(version)
full_url <- endpoint

params <- list(
GameID = pad_id(game_id)
)

full_url <- paste0(endpoint,
"?GameID=",pad_id(game_id))
tryCatch(
expr = {

resp <- request_with_proxy(url = full_url, ...)
resp <- request_with_proxy(url = full_url, params = params, ...)

df_list <- nba_stats_map_result_sets(resp)

Expand Down Expand Up @@ -203,18 +210,21 @@ nba_boxscorefourfactorsv2 <- function(

version <- "boxscorefourfactorsv2"
endpoint <- nba_endpoint(version)
full_url <- endpoint

params <- list(
EndPeriod = end_period,
EndRange = end_range,
GameID = pad_id(game_id),
RangeType = range_type,
StartPeriod = start_period,
StartRange = start_range
)

full_url <- paste0(endpoint,
"?EndPeriod=", end_period,
"&EndRange=", end_range,
"&GameID=",pad_id(game_id),
"&RangeType=", range_type,
"&StartPeriod=",start_period,
"&StartRange=", start_range)
tryCatch(
expr = {

resp <- request_with_proxy(url = full_url, ...)
resp <- request_with_proxy(url = full_url, params = params, ...)

df_list <- nba_stats_map_result_sets(resp)

Expand Down Expand Up @@ -264,18 +274,21 @@ nba_boxscoremiscv2 <- function(

version <- "boxscoremiscv2"
endpoint <- nba_endpoint(version)
full_url <- endpoint

params <- list(
EndPeriod = end_period,
EndRange = end_range,
GameID = pad_id(game_id),
RangeType = range_type,
StartPeriod = start_period,
StartRange = start_range
)

full_url <- paste0(endpoint,
"?EndPeriod=", end_period,
"&EndRange=", end_range,
"&GameID=",pad_id(game_id),
"&RangeType=", range_type,
"&StartPeriod=",start_period,
"&StartRange=", start_range)
tryCatch(
expr = {

resp <- request_with_proxy(url = full_url, ...)
resp <- request_with_proxy(url = full_url, params = params, ...)

df_list <- nba_stats_map_result_sets(resp)

Expand Down Expand Up @@ -325,18 +338,21 @@ nba_boxscorescoringv2 <- function(

version <- "boxscorescoringv2"
endpoint <- nba_endpoint(version)
full_url <- endpoint

params <- list(
EndPeriod = end_period,
EndRange = end_range,
GameID = pad_id(game_id),
RangeType = range_type,
StartPeriod = start_period,
StartRange = start_range
)

full_url <- paste0(endpoint,
"?EndPeriod=", end_period,
"&EndRange=", end_range,
"&GameID=",pad_id(game_id),
"&RangeType=", range_type,
"&StartPeriod=",start_period,
"&StartRange=", start_range)
tryCatch(
expr = {

resp <- request_with_proxy(url = full_url, ...)
resp <- request_with_proxy(url = full_url, params = params, ...)

df_list <- nba_stats_map_result_sets(resp)

Expand Down Expand Up @@ -386,18 +402,21 @@ nba_boxscoreusagev2 <- function(

version <- "boxscoreusagev2"
endpoint <- nba_endpoint(version)
full_url <- endpoint

params <- list(
EndPeriod = end_period,
EndRange = end_range,
GameID = pad_id(game_id),
RangeType = range_type,
StartPeriod = start_period,
StartRange = start_range
)

full_url <- paste0(endpoint,
"?EndPeriod=", end_period,
"&EndRange=", end_range,
"&GameID=",pad_id(game_id),
"&RangeType=", range_type,
"&StartPeriod=",start_period,
"&StartRange=", start_range)
tryCatch(
expr = {

resp <- request_with_proxy(url = full_url, ...)
resp <- request_with_proxy(url = full_url, params = params, ...)

df_list <- nba_stats_map_result_sets(resp)

Expand Down Expand Up @@ -437,13 +456,16 @@ nba_boxscoresummaryv2 <- function(

version <- "boxscoresummaryv2"
endpoint <- nba_endpoint(version)
full_url <- endpoint

params <- list(
GameID = pad_id(game_id)
)

full_url <- paste0(endpoint,
"?GameID=",pad_id(game_id))
tryCatch(
expr = {

resp <- request_with_proxy(url = full_url, ...)
resp <- request_with_proxy(url = full_url, params = params, ...)

df_list <- nba_stats_map_result_sets(resp)

Expand Down Expand Up @@ -489,12 +511,16 @@ nba_boxscorematchups <- function(
endpoint <- nba_endpoint('boxscorematchups')
}

full_url <- paste0(endpoint,
"?GameID=",pad_id(game_id))
full_url <- endpoint

params <- list(
GameID = pad_id(game_id)
)

tryCatch(
expr = {

resp <- request_with_proxy(url = full_url, ...)
resp <- request_with_proxy(url = full_url, params = params, ...)

df_list <- nba_stats_map_result_sets(resp)

Expand Down Expand Up @@ -534,13 +560,16 @@ nba_boxscoreplayertrackv2 <- function(

version <- "boxscoreplayertrackv2"
endpoint <- nba_endpoint(version)
full_url <- endpoint

params <- list(
GameID = pad_id(game_id)
)

full_url <- paste0(endpoint,
"?GameID=",pad_id(game_id))
tryCatch(
expr = {

resp <- request_with_proxy(url = full_url, ...)
resp <- request_with_proxy(url = full_url, params = params, ...)

df_list <- nba_stats_map_result_sets(resp)

Expand Down Expand Up @@ -580,13 +609,16 @@ nba_hustlestatsboxscore <- function(

version <- "hustlestatsboxscore"
endpoint <- nba_endpoint(version)
full_url <- endpoint

params <- list(
GameID = pad_id(game_id)
)

full_url <- paste0(endpoint,
"?GameID=",pad_id(game_id))
tryCatch(
expr = {

resp <- request_with_proxy(url = full_url, ...)
resp <- request_with_proxy(url = full_url, params = params, ...)

df_list <- nba_stats_map_result_sets(resp)

Expand Down Expand Up @@ -630,15 +662,18 @@ nba_gamerotation <- function(

version <- "gamerotation"
endpoint <- nba_endpoint(version)
full_url <- endpoint

params <- list(
GameID = pad_id(game_id),
LeagueID = league_id,
RotationStat = rotation_stat
)

full_url <- paste0(endpoint,
"?GameID=",pad_id(game_id),
"&LeagueID=",league_id,
"&RotationStat=", rotation_stat)
tryCatch(
expr = {

resp <- request_with_proxy(url = full_url, ...)
resp <- request_with_proxy(url = full_url, params = params, ...)

df_list <- purrr::map(1:length(resp$resultSets$name), function(x){
data <- resp$resultSets$rowSet[[x]] %>%
Expand Down Expand Up @@ -696,20 +731,23 @@ nba_boxscoresimilarityscore <- function(

version <- "boxscoresimilarityscore"
endpoint <- nba_endpoint(version)
full_url <- endpoint

params <- list(
Person1Id = person_1_id,
Person1LeagueId = person_1_league_id,
Person1Season = person_1_season,
Person1SeasonType = person_1_season_type,
Person2Id = person_2_id,
Person2LeagueId = person_2_league_id,
Person2Season = person_2_season,
Person2SeasonType = person_2_season_type
)

full_url <- paste0(endpoint,
"?Person1Id=", person_1_id,
"&Person1LeagueId=", person_1_league_id,
"&Person1Season=", person_1_season,
"&Person1SeasonType=", person_1_season_type,
"Person2Id=", person_2_id,
"&Person2LeagueId=", person_2_league_id,
"&Person2Season=", person_2_season,
"&Person2SeasonType=", person_2_season_type)
tryCatch(
expr = {

resp <- request_with_proxy(url = full_url, ...)
resp <- request_with_proxy(url = full_url, params = params, ...)

df_list <- nba_stats_map_result_sets(resp)

Expand Down Expand Up @@ -759,20 +797,23 @@ nba_glalumboxscoresimilarityscore <- function(

version <- "glalumboxscoresimilarityscore"
endpoint <- nba_endpoint(version)
full_url <- endpoint

params <- list(
Person1Id = person_1_id,
Person1LeagueId = person_1_league_id,
Person1Season = person_1_season,
Person1SeasonType = person_1_season_type,
Person2Id = person_2_id,
Person2LeagueId = person_2_league_id,
Person2Season = person_2_season,
Person2SeasonType = person_2_season_type
)

full_url <- paste0(endpoint,
"?Person1Id=", person_1_id,
"&Person1LeagueId=", person_1_league_id,
"&Person1Season=", person_1_season,
"&Person1SeasonType=", person_1_season_type,
"Person2Id=", person_2_id,
"&Person2LeagueId=", person_2_league_id,
"&Person2Season=", person_2_season,
"&Person2SeasonType=", person_2_season_type)
tryCatch(
expr = {

resp <- request_with_proxy(url = full_url, ...)
resp <- request_with_proxy(url = full_url, params = params, ...)

df_list <- nba_stats_map_result_sets(resp)

Expand Down
Loading

0 comments on commit 6369cbf

Please sign in to comment.