Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature Requests #867

Closed
ghost opened this issue Oct 4, 2020 · 40 comments
Closed

New Feature Requests #867

ghost opened this issue Oct 4, 2020 · 40 comments

Comments

@ghost
Copy link

ghost commented Oct 4, 2020

What follows is a lit of features already ready for addition or requested by the community. Drop a 👍 if you'd use, and a 👎 if you wouldn't use it.

UPDATE

  1. Features that the spotDL team think are worth adding will be moved to New Features #912. Please vote over there.
  2. As to the features requested before 23/10/2020, they will be considered purely on the basis of votes received.
  3. Feel free to start conversations in this Issue/thread.
@ghost
Copy link
Author

ghost commented Oct 4, 2020

Quite Mode (#865)

Doesn't display a progress bar.

[will be implemented in the next release]

@ghost
Copy link
Author

ghost commented Oct 4, 2020

Lyrics added if available (#859)

Adds Lyrics to metadata if available.

As of now pulls Lyrics form genius, there might be a change of providers to MusicMatch.

[Will be Implemented in the next release]

@ghost
Copy link
Author

ghost commented Oct 5, 2020

VPN support for spotDL (#862)

Add VPN support for spotDL and handle the download errors that that might cause.

@elmoaaron
Copy link

elmoaaron commented Oct 6, 2020

Download podcast from spotify

[Will be worked on]

@mrdarrengriffin
Copy link

mrdarrengriffin commented Oct 6, 2020

Download by Artist URL would be cool to have. (#874)

[Will be added in next release]

@ghost ghost deleted a comment from s1as3r Oct 6, 2020
@ghost ghost deleted a comment from brayo-pip Oct 6, 2020
@ghost ghost deleted a comment from brayo-pip Oct 6, 2020
@ghost ghost deleted a comment from alexg-k Oct 6, 2020
@ghost
Copy link
Author

ghost commented Oct 7, 2020

Choosing download format (#877)

Ability to choose format download from YouTube.

[Will be worked on in next release]

@ghost ghost deleted a comment from brayo-pip Oct 7, 2020
@ghost ghost deleted a comment from Greenylie Oct 7, 2020
@ghost ghost deleted a comment from alexg-k Oct 7, 2020
@DavidBuchanan314
Copy link

Add metadata to pre-existing local file (#843)

e.g. For if you have a high-quality local file that you want to add metadata/artwork to.

Could be implemented via a flag to specify the local file, which skips the track search and download process.

@brayo-pip
Copy link

brayo-pip commented Oct 10, 2020

Spotify URI support, download songs from URI links like spotify:track:4jVBIpuOiMj1crqd8LoCrJ and spotify:album:4Bp7LKA5Afo1PRoXuQe8qZ just like in Spotdl v2

[Implemented, will be added in next release]

@loftwah
Copy link

loftwah commented Oct 15, 2020

An optional interactive prompt eg spotdl -i --interactive (or whatever argument we wanna give it) that prompts the user for each option as they go (good for those that aren't comfortable with the command line).

#899

This was referenced Oct 16, 2020
@vesper8
Copy link

vesper8 commented Oct 19, 2020

[option] provide a way to number tracks from playlist #599

An option to preserve the order of the tracks when downloading a playlist

@ghost
Copy link
Author

ghost commented Oct 20, 2020

We're reconsidering our feature suggestion system. Give us a day or two. This thread will be locked till then.

@ghost ghost locked and limited conversation to collaborators Oct 20, 2020
@ghost ghost changed the title New Features. New Feature Requests Oct 23, 2020
@ghost ghost mentioned this issue Oct 23, 2020
@ghost
Copy link

ghost commented Nov 5, 2020

Option to disable multiprocessing should that still cause issues for users in the future.

@ghost
Copy link
Author

ghost commented Nov 5, 2020

Maybe not, disabling multiprocessing will almost make each download run 5 times slower. Not a compromise we are willing to make

@aklajnert
Copy link
Contributor

Maybe not, disabling multiprocessing will almost make each download run 5 times slower. Not a compromise we are willing to make

Did you try asyncio? It is very lightweight so it should be even faster than multiprocessing as it doesn't have the startup overhead. Also easier to debug.

@ghost
Copy link
Author

ghost commented Nov 10, 2020

nope. ffmpeg take a lot of CPU power. approx. 20-30%, when you use multiprocessing you can use nearly100% CPU power instead on just 30%. The download conversion process has to run across multiple CPU Cores. hence the need for multiprocessing

@aklajnert
Copy link
Contributor

But it seems that you run ffmpeg as a subprocess, so it doesn't matter if you call the os.system() from a thread, process, or a coroutine - it should release GIL anyway.

@ghost
Copy link
Author

ghost commented Nov 12, 2020

Actually, could you make a mock implementation of what your talking about. I'll test it out.

@Kartikeya99
Copy link

Store some sort of a state such that when the tool is run the next time, it only downloads songs that haven't already been downloaded.

@ghost
Copy link
Author

ghost commented Nov 15, 2020

Store some sort of a state such that when the tool is run the next time, it only downloads songs that haven't already been downloaded.

It already does this

@aklajnert
Copy link
Contributor

Actually, could you make a mock implementation of what your talking about. I'll test it out.

@Mikhail-Zex - see #994 - it seems to have no impact on performance.

@redbrain
Copy link

redbrain commented Dec 4, 2020

Feature request: have a flag to return the YouTube link and stop. This would be useful for piping to other programs.

@Silverarmor
Copy link
Member

Ability to make .m3u files from spotify playlists

.m3u being a "playlist file".

@ghost
Copy link
Author

ghost commented Dec 5, 2020

Ability to make .m3u files from spotify playlists

.m3u being a "playlist file".

Why don't you work on this?

@ghost
Copy link
Author

ghost commented Dec 5, 2020

Feature request: have a flag to return the YouTube link and stop. This would be useful for piping to other programs.

Well, use spotdl as a library to do that. Just create a SongObj or use the search_for_song from search.utils.

CC:@redbrain

@Silverarmor
Copy link
Member

Ability to make .m3u files from spotify playlists
.m3u being a "playlist file".

Why don't you work on this?

okey i will try haha - not the best at programming
https://github.com/Silverarmor/spotifyPL-DL

@ffernn-dev
Copy link

Just a quick idea, Spotify has a huge database of info on songs, maybe SpotDL could use the bpm data and other things of the sort.

@ghost
Copy link
Author

ghost commented Dec 11, 2020

Well, that would be great but YouTube doesn't provide that data for comparison.

@ffernn-dev
Copy link

I mean download the song, and then apply spotify's metadata to it afterwards

@ffernn-dev
Copy link

Also customisable output dir? (without running in a different directory)

@aklajnert
Copy link
Contributor

Also customisable output dir? (without running in a different directory)

I also think that would be nice feature. I think it could be implemented after utilizing some decent argument parser. I think we can pull some changes from #895 and then work on adding some extra arguments.

@ghost
Copy link
Author

ghost commented Dec 12, 2020

I mean download the song, and then apply spotify's metadata to it afterwards

We do this already.

@ghost
Copy link
Author

ghost commented Dec 12, 2020

Also customisable output dir? (without running in a different directory)

I also think that would be nice feature. I think it could be implemented after utilizing some decent argument parser. I think we can pull some changes from #895 and then work on adding some extra arguments.

There's already a way to do this using spotdl as a library. The input just isn't exposed in the cli

@vlalog
Copy link
Member

vlalog commented Dec 12, 2020

Convert songs from spotify to deezer and download them from deezer.

It will be solve some problems:

  1. Downloading the wrong track with the same name
  2. Downloading song with intro sound

@Silverarmor
Copy link
Member

Deprecating this feature request method.

If you want to request a feature, make a new issue and use the FEATURE REQUEST template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests