Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme Various fixes & changes #1054

Merged
merged 7 commits into from Jan 6, 2021
Merged

readme Various fixes & changes #1054

merged 7 commits into from Jan 6, 2021

Conversation

Silverarmor
Copy link
Member

Fixing spelling, grammar and more.
Removed "A few interesting forks" section, as the fork aasmpro/spotify-downloader can only be used with v2.

Fixing spelling, grammar and more.
Removed "A few interesting forks" section, as the fork aasmpro/spotify-downloader can only be used with v2.
@Silverarmor Silverarmor changed the title Various fixes & changes readme Various fixes & changes Dec 22, 2020
Changed updated songs to Spotify's most streamed song of 2020.

Also made a few minor formatting changes
Line 48 is quite important, hence should be bolded as well as italicised
@Silverarmor Silverarmor marked this pull request as ready for review December 22, 2020 09:17
@Silverarmor Silverarmor requested review from phcreery and a user and removed request for phcreery December 22, 2020 09:17
@Silverarmor Silverarmor added the Enhancement Enhancing spotDL label Dec 22, 2020
@ghost
Copy link

ghost commented Dec 24, 2020

Hey @aasmpro, is your spotDL fork still functional?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for <br/> - its more clearer to the reader.

README.md Outdated
@@ -20,108 +20,107 @@ What spotDL does:

### Announcing spotDL v3

We rebuilt spotDL from scratch to be much faster, simpler, and better than the old spotDL. The documentation is also a work in progress.
We rebuilt spotDL from scratch to be faster, simpler, and better than v2 of spotDL. Documentation is also a work in progress.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better than spotDL v2?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation is still a work in progress (why the 'also a work in progress', grammar isn't my strong point - just asking)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation is still a work in progress (why the 'also a work in progress', grammar isn't my strong point - just asking)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better than spotDL v2?

Will fix.

documentation is still a work in progress (why the 'also a work in progress', grammar isn't my strong point - just asking)

Yeah sounds a bit off. Wasn't my wording, was there when I started work on the readme. Will fix.

@Silverarmor
Copy link
Member Author

Go for <br/> - its more clearer to the reader.

I'm sticking with the double space, since using <br> tags in some places, and double spaces elsewhere would be confusing.
Other option would be to move all double spaces to <br> tags - Feel free to commit to the readme-cleanup-1 branch if you want to do that,

Change next-rel-dev to dev. Change to github codeload pages.
Added info about install from master.
@Silverarmor Silverarmor requested a review from a user January 2, 2021 23:09
@Silverarmor Silverarmor merged commit 9bb7210 into master Jan 6, 2021
@Silverarmor Silverarmor deleted the readme-cleanup-1 branch January 6, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhancing spotDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant