Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #272 by refactoring global log to conventional global... #358

Merged
merged 3 commits into from
Sep 22, 2018
Merged

Fixes #272 by refactoring global log to conventional global... #358

merged 3 commits into from
Sep 22, 2018

Conversation

arryon
Copy link
Contributor

@arryon arryon commented Sep 20, 2018

... as used by logzero

ritiek
ritiek approved these changes Sep 22, 2018
View reviewed changes
Copy link
Member

@ritiek ritiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Our logging implementation sure needed some refactoring. Thanks a lot @arryon!

@ritiek ritiek merged commit 32c2ace into spotDL:master Sep 22, 2018
@ritiek ritiek mentioned this pull request Sep 24, 2018
Merged
@arryon arryon deleted the feature/fix-global-logging branch October 3, 2018 13:27
@ritiek ritiek added this to the v1.1.0 milestone Nov 13, 2018
@ritiek ritiek mentioned this pull request Nov 13, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritiek ritiek ritiek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arryon @ritiek