Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #360 #372

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Fixes #360 #372

merged 1 commit into from
Sep 26, 2018

Conversation

arryon
Copy link
Contributor

@arryon arryon commented Sep 26, 2018

No description provided.

@arryon
Copy link
Contributor Author

arryon commented Sep 26, 2018

I'm noticing that coverage is decreased, probably because of the extra branching path. You're free to decline this PR and I'll submit another one with more tests

ritiek
ritiek approved these changes Sep 26, 2018
View reviewed changes
Copy link
Member

@ritiek ritiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and this looks good! Don't worry about the minor coverage decrease.

@ritiek ritiek merged commit fc7d5ab into spotDL:master Sep 26, 2018
@ritiek ritiek mentioned this pull request Sep 26, 2018
Closed
6 tasks
@arryon arryon deleted the bugfix/incorrect-lyrics-m4a branch October 3, 2018 13:27
@ritiek ritiek added this to the v1.1.0 milestone Nov 13, 2018
@ritiek ritiek mentioned this pull request Nov 13, 2018
Closed
6 tasks
@LorenzoMattiussi LorenzoMattiussi mentioned this pull request Oct 13, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritiek ritiek ritiek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arryon @ritiek