Overwrite track file with unique tracks #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also adds a new function |
ritiek
force-pushed
the
duplicates-in-file
branch
from
290515c
to
a5a2791
Compare
linusg
suggested changes
Oct 1, 2018
spotdl/internals.py
Outdated
| with open(text_file, 'r') as listed: | ||
| # read tracks into a list and remove any duplicates | ||
| lines = listed.read().splitlines() | ||
| lines = list(set(lines)) |
There was a problem hiding this comment.
We should use the new remove_duplicates function here IMO...
There was a problem hiding this comment.
Yep, this seems to be causing a merge conflict.
|
Tests are always good! 😁 |
6 tasks
ritiek
force-pushed
the
duplicates-in-file
branch
from
d225c1d
to
7b572ba
Compare
ritiek
force-pushed
the
duplicates-in-file
branch
from
7b572ba
to
e076d11
Compare
|
I also rebased this branch against master and should be ready to merge. |
linusg
approved these changes
Oct 2, 2018
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #370.