Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup.py #383

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Update setup.py #383

merged 1 commit into from
Oct 2, 2018

Conversation

linusg
Copy link
Contributor

@linusg linusg commented Oct 2, 2018

  • Remove py_modules argument from setup (now covered by packages)
  • Fix download URL, old one is not affiliated with this project
  • Add Python 3.7 (which has been out of beta state for a while) to classifiers

ritiek
ritiek approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@ritiek ritiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Thanks!

@ritiek ritiek merged commit 6cb1272 into master Oct 2, 2018
@ritiek
Copy link
Member

ritiek commented Oct 2, 2018

We should also schedule for v1.0.1 soon!

@linusg linusg deleted the update-setup branch October 2, 2018 07:53
@linusg
Copy link
Contributor Author

linusg commented Oct 2, 2018

We should also schedule for v1.0.1 soon!

True! I might collect a list of changes, fixes and new features withing the next few days and create an issue containing an example changelog so we can double-check that.

@ritiek ritiek added this to the v1.1.0 milestone Nov 13, 2018
@ritiek ritiek mentioned this pull request Nov 13, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritiek ritiek ritiek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@linusg @ritiek