Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed test track to one whose lyrics are found #400

Merged
merged 3 commits into from
Oct 19, 2018
Merged

Changed test track to one whose lyrics are found #400

merged 3 commits into from
Oct 19, 2018

Conversation

manveerxyz
Copy link
Contributor

Solved Issue #260

I found a 0:46 second long track that found lyrics through a dry run.

@ritiek
Copy link
Member

ritiek commented Oct 19, 2018

Good find! Travis seems to be failing due to some minor incorrect values. Could you take a look?

@manveerxyz
Copy link
Contributor Author

Yep! I'll check that out!

@manveerxyz
Copy link
Contributor Author

@ritiek I don't know why test_user_playlists is failing, I didn't modify anything related to that file, when I tried to figure out why it was failing I discovered:

  • The first time the Travis build failed, it was attempting to assert 20 == 14 (Job #794.1)

  • After my Fixed incorrect values commit, when the build failed again it was attempting to
    assert 21 == 14 (Job #798.1)

I'm unsure why these values differ.

@manveerxyz
Copy link
Contributor Author

Nevermind! I think I got it, it seems like the user just added some more songs to their playlist. I'll update the tests to reflect this.

@ritiek
Copy link
Member

ritiek commented Oct 19, 2018

it seems like the user just added some more songs to their playlist.

Yep, this is most likely it. I feel it might be a good idea to create our own separate Spotify account for our tests.

Copy link
Member

@ritiek ritiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good work @ManveerBasra!

@ritiek ritiek merged commit 7d321d9 into spotDL:master Oct 19, 2018
@ritiek ritiek added this to the v1.1.0 milestone Nov 13, 2018
@ritiek ritiek mentioned this pull request Nov 13, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants