Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for .m3u playlists #401

Merged
merged 4 commits into from
Oct 20, 2018
Merged

Add support for .m3u playlists #401

merged 4 commits into from
Oct 20, 2018

Conversation

ritiek
Copy link
Member

@ritiek ritiek commented Oct 19, 2018

Supersedes #336.

@ritiek ritiek mentioned this pull request Oct 19, 2018
Closed
@ritiek
Copy link
Member Author

ritiek commented Oct 20, 2018

@linusg @vn-ki This is ready for review whenever you guys find the time. 🔨

linusg
linusg suggested changes Oct 20, 2018
View reviewed changes
Copy link
Contributor

@linusg linusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for this one indentation I wouldn't refrain from merging this just because of some code style inconsistencies.

test/test_list.py Show resolved Hide resolved
spotdl/youtube_tools.py Outdated
if content is None:
log.warning('Skipping {}'.format(track))
else:
log.info('Matched track {0}/{1} ({2})'.format(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a reformatting here, that indentation looks crazy.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if black can make it look better.

spotdl/handle.py Show resolved Hide resolved
spotdl/youtube_tools.py Outdated Show resolved Hide resolved
test/test_list.py Show resolved Hide resolved
test/test_list.py Outdated Show resolved Hide resolved
@linusg
Copy link
Contributor

linusg commented Oct 20, 2018

Looks good! I really look forward to not having to (re)create my playlists manually anymore!

@linusg
Copy link
Contributor

linusg commented Oct 20, 2018

Argh! https://travis-ci.org/ritiek/spotify-downloader/jobs/444037835#L975

@ritiek
Copy link
Member Author

ritiek commented Oct 20, 2018

Welcome back to travis hell.

@linusg
Copy link
Contributor

linusg commented Oct 20, 2018

Let's quickly increment it by one and start with a special playlist just for our tests ASAP?

@ritiek
Copy link
Member Author

ritiek commented Oct 20, 2018

This seems to be a YouTube video mismatch. I changed it to use the same test track as in test_with_metadata.py (https://open.spotify.com/track/2nT5m433s95hvYJH4S7ont). Should hopefully pass now.

@ritiek
Copy link
Member Author

ritiek commented Oct 20, 2018

I still can't weight the ups and downs of mock testing https://github.com/ritiek/spotify-downloader/issues/349#issuecomment-428180489. Just hoping, we would find some tracks that would stay consistent when searching them on YouTube and so our tests won't fail..

@ritiek ritiek merged commit b12ca8c into master Oct 20, 2018
@ritiek ritiek deleted the generate-m3u-playlists branch October 20, 2018 10:49
@ritiek ritiek mentioned this pull request Oct 21, 2018
Closed
6 tasks
@ritiek ritiek added this to the v1.1.0 milestone Nov 13, 2018
@ritiek ritiek mentioned this pull request Nov 13, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linusg linusg linusg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ritiek @linusg