Check and replace slashes with dashes to avoid directory creation error

[manveerxyz]

A potential solution to #321

Since the sanitize_title function of internals.py handles the filename generation, I decided to add a line replacing forward and backslashes with simple dashes there.

I don't know if this was the solution you were looking for, but let me know if there's a better way!

[ritiek]

I don't think we need this check here. The function sanitize_title already expects title to be a string.

[manveerxyz]

The reason I did that, was because the Travis Build failed because I was trying to call .replace() on an int title. Maybe there's an issue with the test?

[linusg]

I think the issue is here:

https://github.com/ritiek/spotify-downloader/blob/b12ca8c78572ea7233fdbc843c8348a113a2852a/spotdl/internals.py#L93

IMO this should be sanitize_title(str(format_tags[tag]), ok="'-_()[]{}"), like two lines below.

Also the code is rather unpythonic:

Iterating over a dict like this is effectively iterating over its keys. Instead of doing this and looking up the value manually (format_tags[tag]), we should iterate over format_tags.values(). Changing a dict while iterating is bad anyways: https://cito.github.io/blog/never-iterate-a-changing-dict/

We might as well use a dict comprehension here:

format_tags_sanitized = {
    k: sanitize_title(str(v), ok="'-_()[]{}")
    if slugification
    else str(v)
    for k, v in format_tags.items()
}

[manveerxyz]

Ok, this seems like a better fix than I proposed so I'll add it in and see if it works!

[manveerxyz]

I don't know why this is failing, I will check it out tomorrow as I am busy today.

[ritiek]

I re-ran the travis build and it seems to have passed this time. Going to merge this in. Thanks!