Doesn't search song on Spotify if "--no-metadata" passed #404
Conversation
|
For some reason the Travis-CI build isn't triggering, or it just isn't showing up on my end. Can someone with write access trigger a rebuild? Or would I have to close/re-open the PR? |
|
I can trigger builds for branches (e. g. Master), but that won't get us anywhere. Seems like Travis missed this PR at all: https://travis-ci.org/ritiek/spotify-downloader/pull_requests GH had some major issues in the last 24 hours, that might be the reason (check their Status page). Not sure what we should do here, TBH... Of course you can run the tests locally. |
|
Oh I see, yeah I when I tried to view this PR about 2 hours ago I only got a 404 page. I'll try running the tests locally when I have time. |
What else would you expect from #404? ;) I'll take a better look at this PR tomorrow when hopefully GitHub gets stable. |
Solves #263
I just added simple checks to
const.args.no_metadatain places where metadata is gathered. As usual, let me know if there's a better way!