New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to control progress reporting #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to enable this option by default, to keep backward compatibility.
That will lead to the defaults being different from the findbugs plugin. Personally I consider the progress option being set by default here as a bug. |
Got it. Then could you:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To pass build with Java9, I've proposed #7. |
@KengoTODA done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@KengoTODA I've missed to update the task mapping (see https://github.com/boidolr/spotbugs-gradle-plugin/commit/e5bd458381ffb7ef7273df6fd6250226576d915f). To you wish to include that as well? |
yes if necessary |
Fixes spotbugs/spotbugs#506. Behaviour and naming is similar to the FindBugs plugin (see https://github.com/gradle/gradle/blob/master/subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/internal/findbugs/FindBugsSpecBuilder.java#L168).