Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to control progress reporting #6

Merged
merged 2 commits into from Feb 20, 2018
Merged

Add option to control progress reporting #6

merged 2 commits into from Feb 20, 2018

Conversation

boidolr
Copy link
Contributor

@boidolr boidolr commented Feb 9, 2018

Copy link
Member

@KengoTODA KengoTODA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to enable this option by default, to keep backward compatibility.

@boidolr
Copy link
Contributor Author

boidolr commented Feb 13, 2018

That will lead to the defaults being different from the findbugs plugin. Personally I consider the progress option being set by default here as a bug.
If you disagree I will change it though.

@KengoTODA
Copy link
Member

Got it. Then could you:

  1. Update CHANGELOG.md to add ## Fixed after Unreleased, then explain this change. this site will help you about how we update CHANGELOG.
  2. Update [version in build.gradle])(https://github.com/spotbugs/spotbugs-gradle-plugin/blob/master/build.gradle#L13) to 1.6.1-SNAPSHOT

KengoTODA
KengoTODA previously approved these changes Feb 18, 2018
Copy link
Member

@KengoTODA KengoTODA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KengoTODA
Copy link
Member

To pass build with Java9, I've proposed #7.

@KengoTODA
Copy link
Member

#7 has been merged. Could you rebase/merge latest master branch? Then build on Java9 should be stable. @boidolr

@boidolr
Copy link
Contributor Author

boidolr commented Feb 19, 2018

@KengoTODA done.

Copy link
Member

@KengoTODA KengoTODA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KengoTODA KengoTODA merged commit bfef820 into spotbugs:master Feb 20, 2018
KengoTODA added a commit that referenced this pull request Feb 20, 2018
@boidolr
Copy link
Contributor Author

boidolr commented Feb 26, 2018

@KengoTODA I've missed to update the task mapping (see https://github.com/boidolr/spotbugs-gradle-plugin/commit/e5bd458381ffb7ef7273df6fd6250226576d915f). To you wish to include that as well?

@KengoTODA
Copy link
Member

yes if necessary

KengoTODA added a commit that referenced this pull request May 22, 2018
KengoTODA added a commit that referenced this pull request May 22, 2018
KevinMcT pushed a commit to KevinMcT/spotbugs-gradle-plugin that referenced this pull request May 22, 2018
KevinMcT pushed a commit to KevinMcT/spotbugs-gradle-plugin that referenced this pull request May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants