fix outputDirectory not work at running spotbugs:spotbugs goal

[exiahuang]

outputDirectory is not working pretty well when I try to run mvn spotbugs:spotbugs command.
I think maybe the htmlTempFile should be use outputDirectory.
Can you take a look of my PR, Thank you.

[hazendaz]

Thanks. Great catch. Will get merged and a release this weekend Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Exia.huangxy ***@***.***> Sent: Wednesday, May 8, 2024 10:01:59 AM To: spotbugs/spotbugs-maven-plugin ***@***.***> Cc: Subscribed ***@***.***> Subject: [spotbugs/spotbugs-maven-plugin] fix outputDirectory not work at running spotbugs:spotbugs goal (PR #807) outputDirectory<https://spotbugs.github.io/spotbugs-maven-plugin/spotbugs-mojo.html#outputDirectory> is not working pretty well when I try to run mvn spotbugs:spotbugs command. I think maybe the htmlTempFile should be use outputDirectory. Can you take a look of my PR, Thank you.

________________________________ You can view, comment on, or merge this pull request online at: #807 Commit Summary * 5591f3c<5591f3c> fix outputDirectory not work at running spotbugs:spotbugs goal File Changes (1 file<https://github.com/spotbugs/spotbugs-maven-plugin/pull/807/files>) * M src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy<https://github.com/spotbugs/spotbugs-maven-plugin/pull/807/files#diff-a8270ec7df0fe9dcf1a1e8120b333c540187439faf5963d157f3a3e846a851e6> (2) Patch Links: * https://github.com/spotbugs/spotbugs-maven-plugin/pull/807.patch * https://github.com/spotbugs/spotbugs-maven-plugin/pull/807.diff — Reply to this email directly, view it on GitHub<#807>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI7SWMNJOCKSZ6AX53TZBIV5PAVCNFSM6AAAAABHNBGATOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI4DKNRYGMZDCMY>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[hazendaz]

@exiahuang Can you show what isn't working for you here? That location is a temp file and there are others in that same spot. project.build.directory is used in a lot of places.

[exiahuang]

@hazendaz

If I set outputDirectory at build tag, run mvnw spotbugs:spotbugs, the output of html is in target/spotbugs.html.
not target/test-output-directory/spotbugs.html.

<build>
	<plugins>
		<plugin>
			<groupId>com.github.spotbugs</groupId>
			<artifactId>spotbugs-maven-plugin</artifactId>
			<!-- <version>4.8.5.1-SNAPSHOT</version> -->
			<version>4.8.5.0</version>
			<dependencies>
				<dependency>
				<groupId>com.github.spotbugs</groupId>
				<artifactId>spotbugs</artifactId>
				<version>4.8.5</version>
				</dependency>
			</dependencies>
			<configuration>
				<htmlOutput>true</htmlOutput>
				<outputDirectory>target/test-output-directory</outputDirectory>
			</configuration>
		</plugin>
	</plugins>
</build>

I Think htmlTempFile is not just a temp file,
it is not like xmlTempFile and sarifTempFile,
because they will be deleted, but htmlTempFile is never.

[hazendaz]

ok I'll need to look more at it. Currently this PR breaks the integration tests....