Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few ASM packages are missing after update to ASM6 #400

Closed
iloveeclipse opened this issue Sep 25, 2017 · 1 comment
Closed

Few ASM packages are missing after update to ASM6 #400

iloveeclipse opened this issue Sep 25, 2017 · 1 comment
Assignees
@iloveeclipse
Labels
bug
Milestone
SpotBugs 3.1.0

Comments

@iloveeclipse
Copy link
Member

@KengoTODA : please don't tag RC6 yet. Manifests in Eclipse show missing ASM package errors. I'm working on it.
@iloveeclipse iloveeclipse added this to the SpotBugs 3.1.0 milestone Sep 25, 2017
@iloveeclipse iloveeclipse self-assigned this Sep 25, 2017
@iloveeclipse iloveeclipse mentioned this issue Sep 25, 2017
Merged
@iloveeclipse
Copy link
Member Author

We always had asm-all, now with #397 we only include asm base and tree.
I think we should just add all asm jars to the dependencies (and so ship them inside the FB) so that 3rd party developers code is not broken. I will prepare PR in a moment.

@iloveeclipse iloveeclipse changed the title ASM Commons are missing Few ASM packages are missing after update to ASM6 Sep 25, 2017
iloveeclipse added a commit that referenced this issue Sep 25, 2017
@iloveeclipse
Add all ASM 6 packages to distribution. Fixes #400
0a791f8
KengoTODA pushed a commit that referenced this issue Sep 25, 2017
@iloveeclipse @KengoTODA
Add all ASM 6 packages to distribution. Fixes #400
e7c8920
@KengoTODA KengoTODA mentioned this issue Nov 5, 2017
Closed
@KengoTODA KengoTODA mentioned this issue Oct 30, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iloveeclipse iloveeclipse

Labels
bug
Projects
None yet
Milestone
SpotBugs 3.1.0
Development

No branches or pull requests
1 participant
@iloveeclipse