Update ASM to 7.0 for full Java 11 support #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It includes full support for Java 11.
|
asm-xml is deleted since 7.0-beta. In asm 6.1, asm-xml is deprecated. |
|
Thanks @wreulicke, fixed it. |
|
I remember that we use asm-xml to keep backward compatibility in Eclipse manifest, see #400 and @iloveeclipse could you review this PR? I'm not sure we can remove |
iloveeclipse
requested changes
Oct 30, 2018
There was a problem hiding this comment.
Please change spotbugs/spotbugs/META-INF/MANIFEST-TEMPLATE.MF and remove xml package, diff:
git diff
diff --git a/spotbugs/META-INF/MANIFEST-TEMPLATE.MF b/spotbugs/META-INF/MANIFEST-TEMPLATE.MF
index 42c88a988..7863fbef1 100644
--- a/spotbugs/META-INF/MANIFEST-TEMPLATE.MF
+++ b/spotbugs/META-INF/MANIFEST-TEMPLATE.MF
@@ -64,8 +64,7 @@ Export-Package: edu.umd.cs.findbugs,
org.objectweb.asm.signature,
org.objectweb.asm.tree,
org.objectweb.asm.tree.analysis,
- org.objectweb.asm.util,
- org.objectweb.asm.xml
+ org.objectweb.asm.util
Bundle-RequiredExecutionEnvironment: JavaSE-1.8
Bundle-ManifestVersion: 2
Bundle-Name: spotbugs
|
We can remove xml package, we have not re-exported it, but we should remove it completely :-) |
|
Thanks, updated the PR. |
iloveeclipse
requested changes
Oct 30, 2018
Co-Authored-By: ijuma <ismael@juma.me.uk>
iloveeclipse
approved these changes
Oct 30, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.ow2.asm:asm-xmlwhich has been removed.Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code