Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NP_NONNULL_PARAM_VIOLATION false-positive #484

Closed
boris-petrov opened this issue Oct 30, 2017 · 4 comments
Closed

NP_NONNULL_PARAM_VIOLATION false-positive #484

boris-petrov opened this issue Oct 30, 2017 · 4 comments
Assignees
@KengoTODA
Labels
bug
Milestone
SpotBugs 3.1.1

Comments

@boris-petrov
Copy link

boris-petrov commented Oct 30, 2017 •
edited

I just hit this, Googled and found:

https://sourceforge.net/p/findbugs/bugs/1403/

I have the same issue - future.complete(null) is giving a NP_NONNULL_PARAM_VIOLATION while it shouldn't.

P.S. SpotBugs 3.1.0.
@KengoTODA KengoTODA mentioned this issue Oct 31, 2017
Open
@KengoTODA KengoTODA self-assigned this Oct 31, 2017
@KengoTODA KengoTODA added the bug label Oct 31, 2017
KengoTODA added a commit that referenced this issue Oct 31, 2017
@KengoTODA
refs #484: reproduce reported problem by JUnit
7f835f9
KengoTODA added a commit that referenced this issue Oct 31, 2017
@KengoTODA
refs #484: fix reproduced bugs
8a4bbfc
KengoTODA added a commit that referenced this issue Oct 31, 2017
@KengoTODA
close #484: add CHANGELOG entry
917ce2c
@KengoTODA KengoTODA added this to the SpotBugs 3.1.1 milestone Oct 31, 2017
henrik242 pushed a commit that referenced this issue Nov 3, 2017
@KengoTODA @henrik242
refs #484: reproduce reported problem by JUnit
457e8cd
henrik242 pushed a commit that referenced this issue Nov 3, 2017
@KengoTODA @henrik242
refs #484: fix reproduced bugs
ac93f80
@ctubbsii ctubbsii mentioned this issue Dec 8, 2017
Closed
@heshamMassoud heshamMassoud mentioned this issue Dec 15, 2017
Closed
@iloveeclipse
Copy link
Member

Hi all, may be I'm wrong, but I don't see commits on the master. Was this only fixed on 3.1.0 branch? We should apply it to 4.0 too.

@iloveeclipse iloveeclipse reopened this Jan 4, 2018
@iloveeclipse
Copy link
Member

Arrgh, there is no way to put the issue to two milestones? OMG.

@iloveeclipse iloveeclipse mentioned this issue Jan 4, 2018
Closed
iloveeclipse added a commit to iloveeclipse/spotbugs that referenced this issue Jan 5, 2018
@iloveeclipse
Merge branch 'release-3.1' into 'master'
858d90d 
This fixes issues spotbugs#519, spotbugs#478, spotbugs#484 and spotbugs#516
@varunnvs92
Copy link

Which version of maven plugin contains this fix?

@ahubold ahubold mentioned this issue Sep 16, 2019
Open
@mikaelstaldal
Copy link
Contributor

Same issue with CompletableFuture.completedStage()

This was referenced Dec 30, 2020
Merged
Closed
KengoTODA pushed a commit that referenced this issue Jan 5, 2021
@mikaelstaldal @KengoTODA
Declare CompletableFuture.completedStage(value) to accept null values
9a4bab7 
Fixes #484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KengoTODA KengoTODA

Labels
bug
Projects
None yet
Milestone
SpotBugs 3.1.1
Development

No branches or pull requests
5 participants
@boris-petrov @KengoTODA @mikaelstaldal @iloveeclipse @varunnvs92