Test project compilation fixes for Eclipse #1317
Conversation
This fixes issue #1316 and finally fixes issue #1315. This change switches from Jaxen 1.1.6 to 1.2.0 to allow compilation of the projects that rely on SpotBugs project with Java 11. Jaxen is a transitive optional dependency of dom4j that we use in SpotBugs. Jaxen 1.1.6 ships org.w3c.dom package, which is also now shipped by JDK in java.xml module. Java 9+ comiler disallow compilation if modules on module path ship same package. So compilation of spotbugsTestCases with Java 11 fails if the target release is 11 with the error: "The package org.w3c.dom is accessible from more than one module: <unnamed>, java.xml". Solution is to update Jaxen to 1.2.0 version, that does not ship org.w3c.dom package anymore. Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
iloveeclipse
force-pushed
the
eclipse_fixes
branch
from
c23d43a
to
4a82208
Compare
| @@ -4,7 +4,7 @@ apply from: "$rootDir/gradle/maven.gradle" | |||
|
|
|||
| dependencies { | |||
| compileOnly 'junit:junit:4.13' | |||
| compileOnly project(':spotbugs') | |||
| testImplementation project(':spotbugs') | |||
There was a problem hiding this comment.
Could you consider to add explanations in CHANGELOG for this change?
I think users of test-harness and test-harness-jupiter needs to this change (from compile-only scope to compile scope).
There was a problem hiding this comment.
I'm not sure how the changed compilation setting here can affect users. Dependencies itself aren't changed. That should be fully transparent for clients.
There was a problem hiding this comment.
@KengoTODA : anything else is missing?
There was a problem hiding this comment.
Hi @KengoTODA ,
to work on #1254, I had to cherry-pick the changes here. Can the changes get merged so I can work with actual master?
Best regards and thanks,
Simeon
There was a problem hiding this comment.
@iloveeclipse
I think changes in test-harness affect its dependency.
That dependency will be changed.
api configuration makes test-harness dependent on that.
There was a problem hiding this comment.
@wreulicke : not sure what do you mean by that. How this change can affect clients of test-harness? I'm not the gradle user, I have no idea why there are multiple dependencies chains invented by gradle, and how that, once a module is compiled, can affect its clients - I really can't understand that. And btw, let assume test-harness clients would be now also depend on spotbugs - what's wrong by that? How that would affect them, they had spotbugs on classpath already anyway?
My problem is that current state on master is not usable with Eclipse, so contributing is a pain, nothing compiles. That is way more severe issue as a theoretical possibility to somehlw break one or two test-harness clients that may exists in the world.
iloveeclipse
force-pushed
the
eclipse_fixes
branch
2 times, most recently
from
94324ed
to
c28885f
Compare
iloveeclipse
force-pushed
the
eclipse_fixes
branch
from
c28885f
to
da0754c
Compare
|
SonarCloud Quality Gate failed.
|
|
Sorry for my late reaction, recently it's a long national holiday in China. I'll submit another PR to make |
This fixes issues #1316 and #1315.
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code