Simplify hash code calculation #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wreulicke
changed the title
ThrawnCA
previously approved these changes
Sep 11, 2018
KengoTODA
requested changes
Sep 14, 2018
|
@KengoTODA added entry to changelog. |
|
oops, you added entry to 3.1.7 version... Plz rebase and move entry under Unreleased. |
wreulicke
changed the base branch from
release-3.1
to
merge-release-3.1-to-master
wreulicke
force-pushed
the
feature/fix-hash-code
branch
from
cfaa259
to
747065f
Compare
|
I rebased on merge-release-3.1-to-master. @KengoTODA |
KengoTODA
approved these changes
Sep 18, 2018
|
merged. don't you need to merge this to for now, your change will be merged to |
OK |
KengoTODA
added a commit
that referenced
this pull request
Sep 25, 2018
KengoTODA
added a commit
that referenced
this pull request
Sep 28, 2018
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to profile spotbugs running in gradle plugin.
I seem that hash code collision in FieldOrMethodDescriptor occurs frequently.
Because FieldOrMethodDescriptor.equals called from HashMap frequently.
after simplified, not called frequently.
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code