Fix issue #758 #760
Merged
Fix issue #758 #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveeclipse
requested changes
Sep 21, 2018
|
@iloveeclipse thank you for your review. I tried to add test to reproduce the issue, but i can not reproduce... I try to debug the issue using reproduction repository. |
|
I reproduced this issue in test code. I will push. |
wreulicke
force-pushed
the
feature/fix-issues-758
branch
4 times, most recently
from
ce08fa9
to
7a45e8a
Compare
|
@iloveeclipse Could you review this PR? |
KengoTODA
force-pushed
the
merge-release-3.1-to-master
branch
from
40659a2
to
6e2a42e
Compare
wreulicke
force-pushed
the
feature/fix-issues-758
branch
from
0f33afc
to
bf3c2d4
Compare
added 2 commits
September 28, 2018 18:05
wreulicke
force-pushed
the
feature/fix-issues-758
branch
from
bf3c2d4
to
25ae4d7
Compare
@iloveeclipse I added regression test. Could you review this PR? |
|
I'm sorry, no free time at all. |
OK. Thanks. |
|
@wreulicke could you propose the same PR for |
@KengoTODA OK. i will propose. |
|
@wreulicke if possible, propose #751 too. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #758. This PR do not treat root cause.
checkcastopcodeMake sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code