Properly reject the promise in client initialisation #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good. this should fix #14 (reply in thread) |
adb-sh
suggested changes
Oct 17, 2022
src/Client.ts
Outdated
| @@ -148,7 +148,7 @@ export class Client { | |||
| * @example const client = await Client.create({ token: "token" }); | |||
| */ | |||
| public static create(options: Omit<ClientOptions, 'onReady'>): Promise<Client> { | |||
There was a problem hiding this comment.
should probably also omit onFail like: Omit<ClientOptions, 'onReady' | 'onFail'>
Arakmar
force-pushed
the
bugfix/client_promise_reject
branch
from
ccdb2cc
to
96b01f6
Compare
adb-sh
approved these changes
Nov 2, 2022
|
The changes have been update in v9.2.5. If you encounter any bugs, open a new issue to resolve it. Thanks for your support 👍 ! |
|
hey :D
this could actually happen, because Client.fetch could throw a
SpotifyAPIError exception, which is not caught.
…On 2022-11-11 12:55, TheSudarsanDev wrote:
@Arakmar [1], By the way, i don't think, there are any possible ways
to get any error at client._init as it is protected by try and catch
in client.fetch itself. Have you ever encountered an error despite the
try and catch?
--
Reply to this email directly, view it on GitHub [2], or unsubscribe
[3].
You are receiving this because you commented.Message ID:
***@***.***>
Links:
------
[1] https://github.com/Arakmar
[2]
#167 (comment)
[3]
https://github.com/notifications/unsubscribe-auth/AJCZQF7NCKXLOQBNOTVT25DWHY63VANCNFSM56PQ66GQ
|
|
Just now, noticed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In case of an authentication error or an API outage during client initialisation, it's not possible to catch the error.
Status