This repository has been archived by the owner on Jan 17, 2019. It is now read-only.
Change to Travis-CI #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks awesome 🚀 |
JohnSundell
approved these changes
Sep 28, 2016
rastersize
force-pushed
the
os/ci-change-to-travis
branch
from
3d44d4b
to
52868cb
Compare
- When using Travis-CI and a public GitHub repository the Codecov token isn’t needed. Yay 🎉
- Makes it possible to enable or disable certain steps if needed.
rastersize
force-pushed
the
os/ci-change-to-travis
branch
from
52868cb
to
54c25ec
Compare
JohnSundell
reviewed
Sep 28, 2016
| branches: | ||
| only: | ||
| - master | ||
| - /^release-.*$/ |
| desc 'Run all CI jobs' | ||
| desc 'Lint the source code and other linteable artifacts' | ||
| lane :lint do | ||
| # pod_lib_lint |
There was a problem hiding this comment.
I guess this is coming later?
There was a problem hiding this comment.
Yep! Depended on your podspec being merged. Will uncomment it in a subsequent PR.
| desc '' | ||
| desc '- LINT: Whether the sources and certain artifacts should be linted,' | ||
| desc ' defaults to `YES`.' | ||
| desc '- RUN_TESTS: Whether unit tests should be ran, defaults to `YES`.' |
There was a problem hiding this comment.
"should be run", "ran" is in the past :)
There was a problem hiding this comment.
I’ll fix that in my subsequent PR (will push very soon).
|
|
||
| defaults to `YES`. | ||
|
|
||
| - RUN_TESTS: Whether unit tests should be ran, defaults to `YES`. |
There was a problem hiding this comment.
Same comment here as for the in-code docs. "Run" instead of "ran".
There was a problem hiding this comment.
Fixing in the next one!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to use Travis-CI.
I think this might work, a bit hard to test until we go public and integrate Travis-CI.