This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Make comparing status more convenient. #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
============================================
+ Coverage 69.95% 70.04% +0.08%
- Complexity 0 681 +681
============================================
Files 143 143
Lines 2949 2951 +2
Branches 239 171 -68
============================================
+ Hits 2063 2067 +4
+ Misses 840 838 -2
Partials 46 46
Continue to review full report at Codecov.
|
|
👍 |
|
👍 I've made this mistake often |
dflemstr
reviewed
Dec 26, 2016
| * @return true if code of this equals code of statusType | ||
| */ | ||
| default boolean equalCode(StatusType statusType) { | ||
| return statusType != null && code() == statusType.code(); |
There was a problem hiding this comment.
Would rather have this throw NPE... Fail early!
There was a problem hiding this comment.
I would agree, I think. @rydenius, is there a reason to expect/permit users to pass in a null statusType to this method?
| * @return true if family of this equals family of statusType | ||
| */ | ||
| default boolean equalFamily(StatusType statusType) { | ||
| return statusType != null && family() == statusType.family(); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More than once I have seen code like this fail:
or
because the status of the response has a different reason phrase. The current solution would be to use
This small patch would simplify this check and also signal to developers that regular equals method might not be what you want to use.