Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Add ERROR_RATIO_4XX to default set of metrics #305

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

bergetp
Copy link

@bergetp bergetp commented Mar 10, 2020

Emit ERROR_RATIO_4XX metric by default and update documentation.

@codecov
Copy link

Codecov bot commented Mar 10, 2020

Codecov Report

Merging #305 into 1.x will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.x     #305      +/-   ##
============================================
+ Coverage     72.79%   72.85%   +0.06%     
+ Complexity      736      735       -1     
============================================
  Files           148      148              
  Lines          3113     3113              
  Branches        174      174              
============================================
+ Hits           2266     2268       +2     
+ Misses          805      802       -3     
- Partials         42       43       +1     
Impacted Files Coverage Δ Complexity Δ
...spotify/apollo/metrics/semantic/MetricsConfig.java 95.45% <ø> (ø) 9.00 <0.00> (ø)
...tify/apollo/request/TrackedOngoingRequestImpl.java 78.57% <0.00%> (-7.15%) 4.00% <0.00%> (-1.00%)
...main/java/com/spotify/apollo/core/ServiceImpl.java 91.03% <0.00%> (+1.03%) 33.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e4109d...6417483. Read the comment docs.

@klaraward
Copy link
Contributor

Just a note that the corresponding 5xx metrics were added in this PR - #301

Copy link
Member

@lepistone lepistone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lepistone lepistone merged commit 021053b into spotify:1.x Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants